Fix EAS CTA condition (#42329)

gravitational · Jun 5, 2024 · 3c95df4 · 3c95df4
1 parent 9f2faaa
commit 3c95df4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...packages/teleport/src/components/ExternalAuditStorageCta/ExternalAuditStorageCta.test.tsx b/...packages/teleport/src/components/ExternalAuditStorageCta/ExternalAuditStorageCta.test.tsx
@@ -20,16 +20,14 @@ import React from 'react';
 import { MemoryRouter } from 'react-router';
 import { render, screen } from 'design/utils/testing';
 
-import { createTeleportContext } from 'teleport/mocks/contexts';
+import { createTeleportContext, getAcl } from 'teleport/mocks/contexts';
 
 import { ContextProvider } from 'teleport/index';
 import cfg from 'teleport/config';
 import { clusters } from 'teleport/Clusters/fixtures';
 
 import { storageService } from 'teleport/services/storageService';
 
-import { getAcl } from 'teleport/mocks/contexts';
-
 import { ExternalAuditStorageCta } from './ExternalAuditStorageCta';
 
 describe('externalAuditStorageCta', () => {
@@ -51,7 +49,7 @@ describe('externalAuditStorageCta', () => {
     });
 
     cfg.isCloud = isCloud;
-    cfg.externalAuditStorage = lockedFeature;
+    cfg.externalAuditStorage = !lockedFeature;
 
     jest
       .spyOn(storageService, 'getExternalAuditStorageCtaDisabled')

diff --git a/web/packages/teleport/src/components/ExternalAuditStorageCta/ExternalAuditStorageCta.tsx b/web/packages/teleport/src/components/ExternalAuditStorageCta/ExternalAuditStorageCta.tsx
@@ -40,7 +40,7 @@ import { ButtonLockedFeature } from '../ButtonLockedFeature';
 export const ExternalAuditStorageCta = () => {
   const [showCta, setShowCta] = useState<boolean>(false);
   const ctx = useTeleport();
-  const featureEnabled = !cfg.externalAuditStorage;
+  const featureEnabled = cfg.externalAuditStorage;
   const userHasAccess = ctx.getFeatureFlags().enrollIntegrationsOrPlugins;
 
   useEffect(() => {
@@ -49,7 +49,7 @@ export const ExternalAuditStorageCta = () => {
         cfg.isCloud &&
         !storageService.getExternalAuditStorageCtaDisabled()
     );
-  }, [cfg.isCloud]);
+  }, [ctx.hasExternalAuditStorage]);
 
   function handleDismiss() {
     storageService.disableExternalAuditStorageCta();