Reject unsupported clients by default #41239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/reject_connections
branch
9 times, most recently
from
940c969
to
1b6442e
Compare
|
PTAL @camscale @ryanclark |
camscale
reviewed
May 10, 2024
camscale
reviewed
May 10, 2024
rosstimothy
force-pushed
the
tross/reject_connections
branch
3 times, most recently
from
38221c0
to
a030af3
Compare
camscale
approved these changes
May 11, 2024
ryanclark
approved these changes
May 13, 2024
#38026 made rejecting client running unusupported major versions an opt-in behavior. Moving forward(v16 and beyond) this is now going to be an opt-out behavior(TELEPORT_UNSTABLE_ALLOW_OLD_CLIENTS=yes). In addition, a cluster alert is now being emitted once for the life of an Auth process if it rejects an unsupported client - with visibility limited to users with token:create permissions.
rosstimothy
force-pushed
the
tross/reject_connections
branch
from
a030af3
to
0baf477
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38026 made rejecting client running unusupported major versions an opt-in behavior. Moving forward(v16 and beyond) this is now going to be an opt-out behavior(TELEPORT_UNSTABLE_ALLOW_OLD_CLIENTS=yes). In addition, a cluster alert is now being emitted once for the life of an Auth process if it rejects an unsupported client - with visibility limited to users with token:create permissions.