Allow auth to reject outdated clients #38026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/deny_old_clients
branch
6 times, most recently
from
fee0e7d
to
5bb13b2
Compare
rosstimothy
force-pushed
the
tross/semver_version
branch
4 times, most recently
from
c21a745
to
046c483
Compare
rosstimothy
force-pushed
the
tross/deny_old_clients
branch
3 times, most recently
from
6b9668d
to
cedcb1a
Compare
|
FYI @zmb3 @fspmarshall @espadolini this implements what we discussed in the scale meeting yesterday. |
rosstimothy
force-pushed
the
tross/deny_old_clients
branch
from
cedcb1a
to
3af4b85
Compare
rosstimothy
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale and
tcsc
rosstimothy
force-pushed
the
tross/semver_version
branch
from
046c483
to
33cd6a4
Compare
Setting `TELEPORT_UNSTABLE_REJECT_OLD_CLIENTS=yes` on the Auth process now enforces that any clients connected are running a supported version. Clients connecting with an unsupported major version are terminated by Auth.
rosstimothy
force-pushed
the
tross/deny_old_clients
branch
from
7058861
to
8879db8
Compare
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Feb 13, 2024
Setting `TELEPORT_UNSTABLE_REJECT_OLD_CLIENTS=yes` on the Auth process now enforces that any clients connected are running a supported version. Clients connecting with an unsupported major version are terminated by Auth.
rosstimothy
added a commit
that referenced
this pull request
Feb 13, 2024
Setting `TELEPORT_UNSTABLE_REJECT_OLD_CLIENTS=yes` on the Auth process now enforces that any clients connected are running a supported version. Clients connecting with an unsupported major version are terminated by Auth.
rosstimothy
added a commit
that referenced
this pull request
May 13, 2024
#38026 made rejecting client running unusupported major versions an opt-in behavior. Moving forward(v16 and beyond) this is now going to be an opt-out behavior(TELEPORT_UNSTABLE_ALLOW_OLD_CLIENTS=yes). In addition, a cluster alert is now being emitted once for the life of an Auth process if it rejects an unsupported client - with visibility limited to users with token:create permissions.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
#38026 made rejecting client running unusupported major versions an opt-in behavior. Moving forward(v16 and beyond) this is now going to be an opt-out behavior(TELEPORT_UNSTABLE_ALLOW_OLD_CLIENTS=yes). In addition, a cluster alert is now being emitted once for the life of an Auth process if it rejects an unsupported client - with visibility limited to users with token:create permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
TELEPORT_UNSTABLE_REJECT_OLD_CLIENTS=yeson the Auth process now enforces that any clients connected are running a supported version. Clients connecting with an unsupported major version are terminated by Auth.Changelog: Optionally permit the auth server to terminate client connections from unsupported versions.