-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update table styles #37276
update table styles #37276
Conversation
4245cb9
to
28dc97f
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
28dc97f
to
d1dddae
Compare
d1dddae
to
1d6bb98
Compare
c6b4fe5
to
234b008
Compare
234b008
to
2023a96
Compare
2023a96
to
49c1c2f
Compare
49c1c2f
to
69a9148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for these changes, @michellescripts ! 🥇
69a9148
to
1ef072a
Compare
1ef072a
to
8cf2222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i got reminded of this from recent activity.
lgtm, non-blocking nits (these are fairly new additions):
the header is transparent:
http://127.0.0.1:9003/?path=/story/teleporte-integrations-enroll-okta--import
when you hover over these rows, it does a slight jump:
http://127.0.0.1:9003/?path=/story/teleport-account-manage-devices-device-list--list-with-devices&globals=theme:Light%20Theme
@michellescripts See the table below for backport results.
|
@kimlisa I had auto-merge on, sigh. Will need to follow up with fixes in another PR. |
This PR updates our existing Table/Data Table styles to match the new look/feel introduced by Unified Resources more closely. It is intended as a "bridge" between the old styles and the new, not a full implementation of the new UI.
This PR does not include the new FilterPanel. The styles are applied to the current layouts as closely as possible (i.e., pagination is functionally the same as before and matches the new filter panel text). Eventually, we may replace pagination with FilterPanel (adding new sort/filter etc. functionality), move the cluster select into that panel and introduce Card views (as applicable).
Screenshots
Supports: #34260
changelog: New table styles