Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update table styles #37276

Merged
merged 2 commits into from
Mar 12, 2024
Merged

update table styles #37276

merged 2 commits into from
Mar 12, 2024

Conversation

michellescripts
Copy link
Contributor

@michellescripts michellescripts commented Jan 25, 2024

This PR updates our existing Table/Data Table styles to match the new look/feel introduced by Unified Resources more closely. It is intended as a "bridge" between the old styles and the new, not a full implementation of the new UI.

This PR does not include the new FilterPanel. The styles are applied to the current layouts as closely as possible (i.e., pagination is functionally the same as before and matches the new filter panel text). Eventually, we may replace pagination with FilterPanel (adding new sort/filter etc. functionality), move the cluster select into that panel and introduce Card views (as applicable).

Screenshots Screenshot 2024-01-25 at 2 56 57 PM Screenshot 2024-01-25 at 2 57 05 PM Screenshot 2024-01-25 at 2 57 12 PM Screenshot 2024-01-25 at 2 57 17 PM Screenshot 2024-01-25 at 2 57 23 PM Screenshot 2024-01-25 at 2 57 29 PM Screenshot 2024-01-25 at 2 57 35 PM Screenshot 2024-01-25 at 2 57 42 PM

Supports: #34260

changelog: New table styles

@michellescripts michellescripts force-pushed the michelle/table-styles branch 2 times, most recently from 4245cb9 to 28dc97f Compare January 25, 2024 22:10
@michellescripts michellescripts marked this pull request as ready for review January 25, 2024 22:11
@github-actions github-actions bot requested review from jimbishopp and r0mant January 25, 2024 22:11
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@michellescripts michellescripts requested review from ryanclark and kimlisa and removed request for r0mant and jimbishopp January 25, 2024 22:25
@michellescripts michellescripts force-pushed the michelle/table-styles branch 2 times, most recently from c6b4fe5 to 234b008 Compare February 21, 2024 18:57
@avatus avatus self-requested a review March 12, 2024 18:07
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from kimlisa March 12, 2024 18:40
Copy link
Contributor

@roraback roraback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these changes, @michellescripts ! 🥇

@michellescripts michellescripts added this pull request to the merge queue Mar 12, 2024
Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i got reminded of this from recent activity.

lgtm, non-blocking nits (these are fairly new additions):

the header is transparent:
http://127.0.0.1:9003/?path=/story/teleporte-integrations-enroll-okta--import
image

when you hover over these rows, it does a slight jump:
http://127.0.0.1:9003/?path=/story/teleport-account-manage-devices-device-list--list-with-devices&globals=theme:Light%20Theme
image

Merged via the queue into master with commit 9e4a6c0 Mar 12, 2024
34 checks passed
@michellescripts michellescripts deleted the michelle/table-styles branch March 12, 2024 20:42
@public-teleport-github-review-bot

@michellescripts See the table below for backport results.

Branch Result
branch/v15 Failed

@michellescripts
Copy link
Contributor Author

@kimlisa I had auto-merge on, sigh. Will need to follow up with fixes in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants