tty_playback: Fix handlePlaybackAction panic on unit16 overflow
#36409
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the addition was happening prior to the cast it was possible to bypass the length check and result in a panic.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
jentfoo
force-pushed
the
jent/stream_recording_improvements
branch
from
00adb8f to
7ff8316
Compare
jentfoo
added
the
no-changelog
zmb3
approved these changes
Jan 8, 2024
avatus
approved these changes
Jan 8, 2024
Comment on lines
-29
to
+36
| handlePlaybackAction(b, player) | ||
| _ = handlePlaybackAction(b, player) |
There was a problem hiding this comment.
what does assigning this to nothing do in comparison to just invoking the method?
There was a problem hiding this comment.
Nothing functionally, but it removes a warning in my IDE. I feel it's cleaner to show when you're explicitly ignoring errors
There was a problem hiding this comment.
that sounds great! Thanks for the info 👍
public-teleport-github-review-bot
bot
removed request for
klizhentas,
Tener,
r0mant and
rudream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panic fix followup from #36168
Because the addition was happening prior to the
intcast it was possible to bypass the length check and result in a panic.In addition this case and others were added as fuzz seeds, and enabled in oss-fuzz.