web: stream recorded SSH/Kube sessions rather than downloading them #36168
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
| @@ -101,6 +101,8 @@ export async function resolveServerMessage( | |||
| } | |||
| } | |||
|
|
|||
| // TODO(zmb3): check with Ryan about replacing this with streaming | |||
There was a problem hiding this comment.
cc @ryanclark how critical is getSessionEvents / getSessionStream given the de-investment in assist?
I'd really like to remove these APIs from the frontend for v15 so that I can remove them from the backend in v16.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
A couple months ago I went and reviewed all of our fuzzing, ensured good seeds and coverage as well as oss-fuzz. So I think we are generally in a good place. However after that effort I did have to remove several tests from oss-fuzz due to a bug on their side resulting in timeout failures that were unable to be reproduced outside of oss-fuzz. Long story short, we should add this to oss-fuzz, but we can not ensure all fuzzing is done within oss-fuzz due to the timeout false positives. And there is not currently any automation to validate what is in oss-fuzz or not. |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
added
the
no-changelog
Prior to this, the web UI would download the entire session recording and store it in JavaScript memory before starting playback. This caused the browser tab to crash when attempting to play back sessions larger than ~5MB. For playback, we use a custom binary protocol rather than the protobuf envelopes that we use for live sessions. The protobuf envelopes only send raw PTY data, there is no place to put the timing data. Adding fields to the envelope would be a disruptive change because our JS codec is hand-rolled and we'd have to make the parsing updates manually. Updates gravitational/teleport-private#1024 Closes gravitational/teleport-private#665 Closes #10578
Prior to this, the web UI would download the entire session recording
and store it in JavaScript memory before starting playback. This caused
the browser tab to crash when attempting to play back sessions larger
than ~5MB.
Updates https://github.com/gravitational/teleport-private/issues/1024
Closes https://github.com/gravitational/teleport-private/issues/665
Closes #10578