Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory leakage in API client caused by otelgrpc interceptors #30767

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

strideynet
Copy link
Contributor

See #30759
Closes #30759

There shouldn't be an issue with multiple clients sharing the "same" interceptor as we don't pass any custom options into the interceptor.

@strideynet strideynet requested a review from rosstimothy August 21, 2023 15:16
@strideynet strideynet marked this pull request as ready for review August 21, 2023 15:16
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @strideynet 🙌 !

@strideynet strideynet added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@strideynet strideynet added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit d972008 Aug 24, 2023
@strideynet strideynet deleted the strideynet/fix-otelgrpc-leak-inclient branch August 24, 2023 21:11
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v11 Create PR
branch/v12 Create PR
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API client leaks memory otelgrpc instrumentation
3 participants