Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API client leaks memory otelgrpc instrumentation #30759

Closed
strideynet opened this issue Aug 21, 2023 · 3 comments · Fixed by #30767
Closed

API client leaks memory otelgrpc instrumentation #30759

strideynet opened this issue Aug 21, 2023 · 3 comments · Fixed by #30767
Labels
bug machine-id

Comments

@strideynet
Copy link
Contributor

tbot regularly creates clients as its certificates rotate and whilst these clients are closed properly, the underlying metric created by otelgrpc.UnaryClientInterceptor is not tidied up by the looks of things - this causes a slow leak. The following data is from a tbot running over a several week period:

image
image
image
@strideynet strideynet mentioned this issue Aug 21, 2023
Merged
@strideynet
Copy link
Contributor Author

Reported in open-telemetry/opentelemetry-go-contrib#4226

@strideynet
Copy link
Contributor Author

We'll work around this by leveraging a sync.Once to reuse the interceptors across clients created in the application lifetime.

@strideynet
Copy link
Contributor Author

Looks like ArgoCD ran into the same problem: argoproj/argo-cd#15148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug machine-id
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce memory leakage in API client caused by otelgrpc interceptors gravitational/teleport
1 participant
@strideynet