(v9) Security fixes #13301
Merged
(v9) Security fixes #13301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes two fixes: 1. Enforce an application/json Content-Type server-side. 2. When checking the bearer token, verify that the user associated with the token matches the user associated with the cookie.
When data flow is disabled in TermManager (at the beginning or when TermManager.Off was called) we should ignore all input we receive (currently we buffer it)
github-actions
bot
added
the
tsh
Joerger
approved these changes
Jun 8, 2022
zmb3
approved these changes
Jun 8, 2022
jakule
reviewed
Jun 8, 2022
| "golang.org/x/sys/unix" | ||
| ) | ||
|
|
||
| func TestAgentSocketPermissions(t *testing.T) { |
There was a problem hiding this comment.
This test can run as a root. The name needs to be changed: https://github.com/gravitational/teleport/blob/master/Makefile#L627-L638
| require.True(t, isRoot()) | ||
| }) | ||
|
|
||
| nonRoot, err := user.LookupId("1000") |
There was a problem hiding this comment.
This is system dependent. Not every OS has a user with ID 1000.
| require.True(t, !isRoot()) | ||
|
|
||
| err := unix.Unlink(agentServer.Path) | ||
| require.Error(t, err) |
There was a problem hiding this comment.
We should probably check what error is returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from a private release.