Check oidc email_verified claim #12140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add test coverage? |
|
@zmb3 This seems to work fine on Google and Okta after manual testing. |
gabrielcorado
approved these changes
Apr 28, 2022
zmb3
reviewed
Apr 29, 2022
zmb3
requested changes
Apr 29, 2022
zmb3
approved these changes
Apr 29, 2022
xacrimon
added a commit
that referenced
this pull request
May 2, 2022
Merged
xacrimon
added a commit
that referenced
this pull request
May 3, 2022
xacrimon
added a commit
that referenced
this pull request
May 3, 2022
|
Would we ever consider creating a way to disable this via the config? |
|
We could, is this causing problems for anyone? Generally I made the assumption that disabling this is very bad security practice since the field set to false means that the IdP is telling us we can't really trust that the email is controlled by the user in question. |
|
I have a meeting with the customer this afternoon. I'll try to understand why the email_verified claim can't be set to true. If they can't set email_verified claim to true, I'll create a Github issue to add a "switch" and link it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not check the email_verified claim when validating OIDC callbacks.
This is not always set, but if it's set to false, the OIDC provider does not guarantee the authenticity of the email address and Teleport should reject it.
This will only be manually tested.