Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden SQLite permissions #12096

Merged
merged 5 commits into from
May 2, 2022
Merged

Harden SQLite permissions #12096

merged 5 commits into from
May 2, 2022

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented Apr 19, 2022 •
edited
Loading

Hardens SQLite permissions according to report guidelines:

  • Change directory permissions to 0700
  • Change database permissions to 0600 on creation

@xacrimon xacrimon requested review from zmb3 and removed request for r0mant, zmb3, xinding33 and ptgott April 19, 2022 21:15
zmb3
zmb3 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

We do have FileMode constants (or lack there of) scattered throughout the codebase. At some point we should evaluate consolidating them.

LKozlowski
LKozlowski approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@LKozlowski LKozlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xacrimon xacrimon enabled auto-merge (squash) April 25, 2022 09:02
jakule
jakule reviewed Apr 25, 2022
View reviewed changes
lib/backend/lite/lite.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from jakule April 26, 2022 11:23
@xacrimon xacrimon merged commit e9fb1e8 into master May 2, 2022
xacrimon added a commit that referenced this pull request May 2, 2022
@xacrimon
Harden SQLite permissions (#12096)
c36ee28
@xacrimon xacrimon mentioned this pull request May 2, 2022
Merged
xacrimon added a commit that referenced this pull request May 3, 2022
@xacrimon
Harden SQLite permissions (#12096)
59c11d8
xacrimon added a commit that referenced this pull request May 3, 2022
@xacrimon
[v9] Rollup backport (#12360)
6eff5c4 
* Harden SQLite permissions (#12096)

* Check oidc email_verified claim (#12140)

* Limit Kubernetes connections (#12275)

* Handle DynamoDB pay-per-request mode correctly (#12295)
@zmb3 zmb3 deleted the joel/TEL-Q122-14 branch April 26, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@LKozlowski LKozlowski LKozlowski approved these changes

@timothyb89 timothyb89 timothyb89 approved these changes

@jakule jakule Awaiting requested review from jakule

Assignees
No one assigned
Labels
backport-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xacrimon @timothyb89 @LKozlowski @zmb3 @jakule