Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Backport #11389 #11412

Merged
merged 3 commits into from
Mar 25, 2022
Merged

[v8] Backport #11389 #11412

merged 3 commits into from
Mar 25, 2022

Conversation

rosstimothy
Copy link
Contributor

Backports #11389

@rosstimothy
Fix panic in getWebConfig (#11389)
976cd6b 
Refactored the usage of the types.AuthPreference returned from
GetAuthPreference so that it is only accessed if there were no
errors.
@rosstimothy rosstimothy enabled auto-merge (squash) March 24, 2022 15:29
@rosstimothy rosstimothy force-pushed the v8-backport-11389 branch 2 times, most recently from 0ea0ffd to 976cd6b Compare March 25, 2022 16:19
@rosstimothy rosstimothy merged commit eb92c9f into branch/v8 Mar 25, 2022
@rosstimothy rosstimothy deleted the v8-backport-11389 branch March 25, 2022 19:15
@alexatcanva alexatcanva mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallinsky smallinsky smallinsky approved these changes

@xacrimon xacrimon xacrimon approved these changes

@codingllama codingllama codingllama approved these changes

@r0mant r0mant r0mant approved these changes

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosstimothy @r0mant @codingllama @xacrimon @smallinsky