-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in getWebConfig #11389
Merged
Merged
Fix panic in getWebConfig #11389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the usage of the types.AuthPreference returned from GetAuthPreference so that it is only accesed if there were no errors.
codingllama
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
xacrimon
approved these changes
Mar 23, 2022
zmb3
approved these changes
Mar 23, 2022
Merged
rosstimothy
added a commit
that referenced
this pull request
Mar 24, 2022
Refactored the usage of the types.AuthPreference returned from GetAuthPreference so that it is only accessed if there were no errors.
rosstimothy
added a commit
that referenced
this pull request
Mar 24, 2022
Refactored the usage of the types.AuthPreference returned from GetAuthPreference so that it is only accessed if there were no errors.
Merged
rosstimothy
added a commit
that referenced
this pull request
Mar 24, 2022
rosstimothy
added a commit
that referenced
this pull request
Mar 25, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the usage of the
types.AuthPreference
returned fromGetAuthPreference
so that it is only accessed if there were noerrors.