helm: Refine snapshotting for Deployment/StatefulSet in unit tests #11279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
force-pushed
the
gus/helm/refine-snapshotting
branch
from
089e5b9 to
79a6f15
Compare
This was referenced Mar 21, 2022
zmb3
approved these changes
Mar 21, 2022
russjones
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing a couple of Helm PRs to include unit testing has made me realise that there's very little point in snapshotting the entire
Deployment/StatefulSetmanifest because it has thechecksum/configannotation which changes every time the Teleport config file is altered.This will get very annoying to deal with and mean that any PRs which alter the Teleport config will have to be merged one by one and then rebased and modified again with another commit to handle the updated checksum before merging. This is exactly the same thing that I had to do over and over for Drone while I was iterating on it, so I'm making sure to stop this early!
All the interesting stuff is in
spec.template.spec, so this PR changes the relevant tests to just snapshot that instead. We still snapshot the entire config in theConfigtest suite.