helm: Adds missing namespaces to ConfigMap #11032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
approved these changes
Mar 10, 2022
|
Depends on #11279 |
webvictim
force-pushed
the
gus/helm/add-missing-namespaces
branch
from
9dec4c7 to
3279591
Compare
|
Cherry-picking 87be59c to this branch as well to save opening a separate PR. |
probakowski
approved these changes
Mar 22, 2022
webvictim
added a commit
that referenced
this pull request
Mar 22, 2022
webvictim
added a commit
that referenced
this pull request
Mar 24, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigMapfor both theteleport-clusterandteleport-kube-agentcharts was missing anamespace:parameter. This is transparently fixed for you when you runhelm install --namespace x, but applying the output ofhelm template --namespace x(as some wrapper tools do) would result in theConfigMapliving in the wrong namespace.Backports required:
branch/v9(I'm deliberately not backporting this to
branch/v8in case it's a breaking change in some environments which depend on the old behaviour)