add a Team receiving widget #138

mattbk · 2016-06-19T23:03:32Z

Lots to do. Starting with a clean/working duplication of v1 to v2, then will start chipping away.

So we should build a v2 widget that is cloned and then modified from the v1 widget. This new version will handle giving in the same way, but will handle taking (for ~users) and receiving (for teams).

Clean/working duplication of v1 to v2
Rename tests according to v1/v2.
Incorporate Switch ~user widgets over to Gratipay 2.0 #133.
Incorporate parts of Widgets work with both ~users and Teams #112 that are useful for Teams.

A different PR:

Fix v1 to work with Gratipay API changes? "Receiving" is now "taking" in public.json.
- Yes. Widgets for Gratipay 2.0 #103 (comment): "Widgets already in the wild should be updated to reflect giving and taking for ~users."
- This has been done for v2 under the current PR, but no changes to v1 have been made.

Tests will measure different things for each version.

Leave test/example source data in test/ root rather than duplicating across versions; data should be the same and reflect current Gratipay API.

All pass right now.

Receiving can no longer be anonymous (giving can). Same as 91bbd00c0826f49b825 2a17cbe8bd561d32772db.

Change "receiving" language to "taking" language.

mattbk · 2016-06-21T01:39:11Z

#133 changes are incorporated.

mattbk · 2016-06-21T02:01:34Z

Now, to the fun part.

I think a better approach will be to let data-gratipay-username continue to only mean ~user username, and write new widget code for Teams.
#112 (comment)

An example, using default-widget.html:

<!doctype html>
<script>grtpAPI = '/lib/v2/'</script>
<script>gratipayURI = '/test/gratipay.com/'</script>

<body>
    <script src="/lib/v2.js" data-gratipay-username="rummik" async></script>
</body>

Where it says data-gratipay-username= I should be able to put data-gratipay-teamslug= (TBD), and then pick it up in v2.js and go from there.

Only works for default-widget-team.html. Enough for tonight.

mattbk · 2016-06-25T14:38:31Z

Forgot to test before committing.

Leaving the others for now, will step through as needed.

Stripping this down to basic functionality so teams can start using it.

Teams don’t give.

mattbk · 2016-06-25T16:54:52Z

I think it's ready for review. Very simple and stripped down. Does not modify anything from v1.

Only includes default and custom widgets and associated tests (see /test/v2).
Removes giving entirely.
Realigns "taking" into "receiving" to match Gratipay API.

Example using default-widget.html:

<!doctype html>
<script>grtpAPI = '/lib/v2/'</script>
<script>gratipayURI = '/test/gratipay.com/'</script>

<body>
    <script src="/lib/v2.js" data-gratipay-teamslug="gratipay" async></script>
</body>

chadwhitacre · 2016-06-29T18:25:22Z

lib/v2/api.js

+    // Define window.Gratipay if it hasn't previously been defined
+    if (!window.Gratipay) {
+        // For legacy reasons, have window.Gittip also be defined
+        window.Gittip =


Let's remove all the Gittip references from v2, ya?

chadwhitacre · 2016-06-29T18:26:10Z

Punchlist

rebase on master
excise Gittip from v2—add a Team receiving widget #138 (comment) —done in 361df4c
drop goal—add a Team receiving widget #138 (comment) —done in ~~deff3bf~~ cc4657e
drop identity—add a Team receiving widget #138 (comment) —done in ~~fd7a0c6~~ dbfde48
update nomenclature in tests—add a Team receiving widget #138 (comment) and add a Team receiving widget #138 (comment) and add a Team receiving widget #138 (comment) —done in ~~fd7a0c6~~ 72b886d
update Blogger widget—add a Team receiving widget #138 (comment) —done in ~~fa312e8~~ 45575c9
we should update the README to only document the v2 API —done in ~~608b1f0~~ b71ac87
update grtpAPI—add a Team receiving widget #138 (comment) and add a Team receiving widget #138 (comment) —done in ~~ddd038f~~ ba6c753

chadwhitacre · 2016-06-29T18:27:13Z

Here's a diff between v1 and v2 in cc11356:

https://gist.github.com/whit537/2411be1bb1037d4e6cfb15310f25715f

mattbk · 2016-06-29T18:33:55Z

Comments sound good so far, can't test until tonight at earliest.

Here's a diff between v1 and v2 in cc11356:

Should I be using this information for something?

chadwhitacre · 2016-06-29T18:35:51Z

Should I be using this information for something?

Nope. That's just FYI at this point—mostly for me and @kaguillera as we review this. :)

Comments sound good, can't test until tonight at earliest.

More comments coming (probably). I will update the punchlist and let you know when I'm done reviewing. :)

chadwhitacre · 2016-06-29T19:03:07Z

test/v2/custom-widget.html

+        <a class="gratipay-profile-link">profile link</a><br>
+        Identity: <span class="gratipay-identity"></span><br>
+        Receiving: <span class="gratipay-receiving"></span><br>
+        Goal: <span class="gratipay-goal"></span><br>


We can drop goal throughout both the v1 and v2 APIs. We haven't had goals since ... I don't know, but not for a while now.

chadwhitacre · 2016-06-30T00:44:19Z

test/v2/custom-widget.html

+    <div data-gratipay-teamslug="gratipay" data-gratipay-widget="custom">
+        Username: <span class="gratipay-slug"></span>
+        <a class="gratipay-profile-link">profile link</a><br>
+        Identity: <span class="gratipay-identity"></span><br>


We can drop identity, too. We're just dealing with Teams now, which are all plural.

chadwhitacre · 2016-06-30T01:21:08Z

lib/v2.js

+    var Gratipay = window.Gratipay || {};
+
+    // Where's our files?
+    var api = window.grtpAPI || 'https://grtp.co/v1/';


Should be v2.

chadwhitacre · 2016-06-30T01:46:22Z

Alright, @mattbk. I'm ready to merge this if you are. Even if we end up going a different direction on #103 with more of a Gumroad-style button, this work is basically done and is an improvement over having nothing for 2.0 widgets.

mattbk · 2016-06-30T14:37:42Z

👍

mattbk added 5 commits June 19, 2016 17:38

Make clean copy of v1

6ff5189

Separate v1 and v2 tests

156eec4

Tests will measure different things for each version.

Assign tests to correct version

53522a5

Leave test/example source data in test/ root rather than duplicating across versions; data should be the same and reflect current Gratipay API.

Rename and fix paths for v1 tests

c23f9f3

Rename v2 tests to identify

ba6c334

All pass right now.

mattbk self-assigned this Jun 19, 2016

mattbk added 2 commits June 20, 2016 20:24

Remove anonymous receiving.

d1f4861

Receiving can no longer be anonymous (giving can). Same as 91bbd00c0826f49b825 2a17cbe8bd561d32772db.

Change all "receiv*" to "tak*".

4708074

Change "receiving" language to "taking" language.

mattbk added this to the Make Widgets 2.0 milestone Jun 21, 2016

mattbk mentioned this pull request Jun 21, 2016

Product Radar 9 gratipay/inside.gratipay.com#677

Closed

Add basic team receiving functionality.

acbadb0

Only works for default-widget-team.html. Enough for tonight.

mattbk added 5 commits June 25, 2016 11:15

Fix test for team widget.

1278ec8

Leaving the others for now, will step through as needed.

Remove legacy widgets.

2e030f7

Update test/example widgets.

a685ae9

Remove anonymous giving and extra tests and fix tests.

23ec53d

Remove extra widgets.

09ea5a2

Stripping this down to basic functionality so teams can start using it.

mattbk mentioned this pull request Jun 25, 2016

Widgets for Gratipay 2.0 #103

Closed

6 tasks

mattbk added 2 commits June 25, 2016 11:50

Remove giving.

9b03787

Teams don’t give.

Fix missed "taking" reference.

cc11356

mattbk added the Review label Jun 25, 2016

mattbk mentioned this pull request Jun 29, 2016

Product Radar 10 gratipay/inside.gratipay.com#690

Closed

chadwhitacre mentioned this pull request Jun 29, 2016

Core Radar 65 gratipay/inside.gratipay.com#685

Closed

chadwhitacre reviewed Jun 29, 2016
View reviewed changes

chadwhitacre changed the title ~~Widgets v2~~ add a Team receiving widget Jun 29, 2016

Merge branch 'master' into widgets-v2

a3800e9

chadwhitacre reviewed Jun 29, 2016
View reviewed changes

Prune Gittip from api/v2

361df4c

chadwhitacre reviewed Jun 30, 2016
View reviewed changes

chadwhitacre added 4 commits June 29, 2016 21:15

Update Blogger widget for v2

45575c9

Remove goal from v2 API

cc4657e

Remove identity from v2 api

dbfde48

Update nomenclature in tests

72b886d

chadwhitacre force-pushed the widgets-v2 branch from afe0c0a to 608b1f0 Compare June 30, 2016 01:15

chadwhitacre reviewed Jun 30, 2016
View reviewed changes

chadwhitacre added 2 commits June 29, 2016 21:39

Update README for v2

b71ac87

Update grtpAPI

ba6c753

chadwhitacre force-pushed the widgets-v2 branch from ddd038f to ba6c753 Compare June 30, 2016 01:40

chadwhitacre merged commit e99076c into master Jun 30, 2016

chadwhitacre deleted the widgets-v2 branch June 30, 2016 15:04

This was referenced Jun 30, 2016

Tech Radar 10 gratipay/inside.gratipay.com#687

Closed

Remove references to goals #125

Closed

Remove goal progress from custom widgets #122

Closed

Use ~ before usernames #102

Closed

mattbk mentioned this pull request Jul 2, 2016

Re-add dollar sign to default widget #140

Closed

mattbk mentioned this pull request Jul 14, 2016

Receiving value should go to the team page but is undefined #109

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a Team receiving widget #138

add a Team receiving widget #138

mattbk commented Jun 19, 2016 •

edited

Loading

mattbk commented Jun 21, 2016

mattbk commented Jun 21, 2016 •

edited

Loading

mattbk commented Jun 25, 2016 •

edited

Loading

mattbk commented Jun 25, 2016

chadwhitacre Jun 29, 2016

chadwhitacre commented Jun 29, 2016 •

edited

Loading

chadwhitacre commented Jun 29, 2016

mattbk commented Jun 29, 2016 •

edited

Loading

chadwhitacre commented Jun 29, 2016

chadwhitacre Jun 29, 2016 •

edited

Loading

chadwhitacre Jun 30, 2016

chadwhitacre Jun 30, 2016

chadwhitacre commented Jun 30, 2016

mattbk commented Jun 30, 2016

add a Team receiving widget #138

add a Team receiving widget #138

Conversation

mattbk commented Jun 19, 2016 • edited Loading

mattbk commented Jun 21, 2016

mattbk commented Jun 21, 2016 • edited Loading

mattbk commented Jun 25, 2016 • edited Loading

mattbk commented Jun 25, 2016

chadwhitacre Jun 29, 2016

Choose a reason for hiding this comment

chadwhitacre commented Jun 29, 2016 • edited Loading

Punchlist

chadwhitacre commented Jun 29, 2016

mattbk commented Jun 29, 2016 • edited Loading

chadwhitacre commented Jun 29, 2016

chadwhitacre Jun 29, 2016 • edited Loading

Choose a reason for hiding this comment

chadwhitacre Jun 30, 2016

Choose a reason for hiding this comment

chadwhitacre Jun 30, 2016

Choose a reason for hiding this comment

chadwhitacre commented Jun 30, 2016

mattbk commented Jun 30, 2016

mattbk commented Jun 19, 2016 •

edited

Loading

mattbk commented Jun 21, 2016 •

edited

Loading

mattbk commented Jun 25, 2016 •

edited

Loading

chadwhitacre commented Jun 29, 2016 •

edited

Loading

mattbk commented Jun 29, 2016 •

edited

Loading

chadwhitacre Jun 29, 2016 •

edited

Loading