Widgets work with both ~users and Teams #112

mattbk · 2016-02-07T20:16:25Z

I took a crack at aligning the default widget code with the new public.json output from Gratipay.com. Comments are welcome; I'm sure there are ways to break what I've done.

Here’s a hack to make the link work. Closes #109. Also added a team widget example for debugging.

public.json structure has changed since these data were created.

Closes #111. Not sure if there is a use case for anonymous anymore or not. Also fixed bad quotation mark.

chadwhitacre · 2016-02-08T03:02:47Z

Nice! I've made a Review label in grtp.co so we could apply it here. :)

Anyone up for reviewing this? If not I'll get to it when I can ...

mattbk · 2016-02-08T19:12:53Z

Should I worry about these checks failing?

chadwhitacre · 2016-02-08T20:45:45Z

@mattbk Yes. It looks like our linter ain't happy with your formatting. ;-)

mattbk · 2016-02-08T22:44:30Z

Okay, I see it now.

lib/v1/api.js
131 | text('receiving', (data.taking)? '$' + data.taking : '$' + data.receiving);
^ [W015] Expected 'text' to have an indentation at 17 instead at 21.
141 | }
^ [W015] Expected '}' to have an indentation at 17 instead at 21.

mattbk · 2016-02-09T15:59:54Z

I think tests are based on the old public.json and are failing because I downloaded new versions of the test public.json files?

mattbk · 2016-02-10T16:29:29Z

Looking at these files in order?

Files: test/test_custom-widget-legacy.js,
test/test_custom-widget.js,
test/test_default-widget-anonymous.js,
test/test_default-widget-legacy.js,
test/test_default-widget.js,
test/test_expose-api-to-iframe.js,
test/test_giving-widget-anonymous.js,
test/test_giving-widget-legacy.js,
test/test_giving-widget.js -> test

mattbk · 2016-02-10T17:05:23Z

I think it's failing on this part of api.js for certain tests.

  // Set up links and username before requesting public.json
            link('profile-link', gratipayURI + encodeURIComponent(username) + '/');
            link('link', gratipayURI);
            text('username', username);
            text('identity', 'I');

mattbk · 2016-02-11T17:04:28Z

That works. Hot.

chadwhitacre · 2016-02-11T17:09:55Z

/me waiting for Travis to run green ...

This makes test results easier to read.

mattbk · 2016-02-11T17:13:47Z

/me waiting for Travis to run green ...

Hold your horses, I have to understand how tests work first.

chadwhitacre · 2016-02-11T17:14:31Z

!m @mattbk

mattbk · 2016-02-11T20:32:34Z

It looks like only giving can be anonymous now, not receiving. That doesn't help my brain work better, though.

There is no more anonymous receiving, only anonymous giving.

public.json now returns "null" rather than "anonymous".

Oops.

This reverts commit 1b2d3af.

This reverts commit 6efa3b8.

Not sure what this line does, but making sure this is the kicker.

This reverts commit c005194, reversing changes made to 3c0ddb3.

This reverts commit 066ba6c.

mattbk · 2016-04-02T17:19:19Z

I ended up merging trailing-zero into this branch because this is what it was based on. Next up is a full review by me of what I actually did.

mattbk · 2016-04-02T17:29:36Z

I'm satisfied with the final product; it's a heck of a mess of commits, though. 🐺

@whit537, @techtonik, any comments?

aandis · 2016-04-03T05:57:18Z

it's a heck of a mess of commits

Github now allows squash and merge commits! 💃

chadwhitacre · 2016-04-09T23:49:03Z

lib/v1/api.js

+
+                // If username exists, it's a ~user, not a team. Build URL accordingly.
+                if (data.username) {
+                    link('profile-link', gratipayURI + encodeURIComponent(data.username) + '/');


Don't we want to insert a ~ here?

I'm not sure how those rewrites end up working. I know that if I don't put a ~ in, it still works. If it is better to include the ~, then we can do that.

chadwhitacre · 2016-04-10T00:08:38Z

As I read it, this PR tries to treat the data-gratipay-username of widgets-in-the-wild as either a ~user username or a Team slug.

If it's a username, we use that to construct the profile link, and expect that receiving won't be present but taking will be.
If it's a slug, we use that to construct the profile link, and expect receiving to be present.

I'm not sure that's the right approach to take, both because it introduces tech debt into our widget code ("receiving" in this PR no longer means "receiving," it means "receiving or taking"), and because it's not as true to our new data model as it could be. I think a better approach will be to let data-gratipay-username continue to only mean ~user username, and write new widget code for Teams. See #103 (comment) for further discussion.

I propose that we whittle this PR down to just the test changes that make sense to keep, and pick up with additional changes in new PRs.

mattbk · 2016-04-11T13:27:40Z

I propose that we whittle this PR down to just the test changes that make sense to keep, and pick up with additional changes in new PRs.

I can work on that, unless someone else wants to jump in.

mattbk · 2016-04-20T13:48:54Z

just the test changes

I might need clarification. You mean make this PR about ~users and build a new PR for teams?

chadwhitacre · 2016-04-20T15:30:06Z

I actually meant to keep the extra info in the test strings like below, and make new PRs for ~user and Team changes.

mattbk · 2016-04-20T16:51:51Z

Got it. Now I get to learn how to clone my PR without losing things.

…xperiments

Based on discussion at #112 (comment). Breaking up that PR into more manageable chunks.

…into team-experiments

Based on discussion at #112 (comment). Breaking up that PR into more manageable chunks.

mattbk · 2016-05-13T18:19:35Z

Shuttering this pull request because it changes v1 widgets, which is not the plan at #103 (comment).

Keeping the branch in place until I grab what I want for a real v2.

mattbk added 3 commits February 7, 2016 13:30

Fix receiving link

cf6b17c

Here’s a hack to make the link work. Closes #109. Also added a team widget example for debugging.

Update test/example data

04a5fcb

public.json structure has changed since these data were created.

Fix anonymous receiving

132e0f7

Closes #111. Not sure if there is a use case for anonymous anymore or not. Also fixed bad quotation mark.

mattbk added this to the Widgets 2.0 milestone Feb 7, 2016

chadwhitacre added the Review label Feb 8, 2016

Fix indents

8e69562

mattbk self-assigned this Feb 9, 2016

See if changing test title makes tests easier to read

bb98204

Make title tests more specific

1166a52

This makes test results easier to read.

chadwhitacre mentioned this pull request Feb 11, 2016

Radar 45 gratipay/inside.gratipay.com#494

Closed

Update anon-user public.json

17dace3

mattbk added 7 commits February 11, 2016 14:35

Remove anonymous receiving test

ff9f786

There is no more anonymous receiving, only anonymous giving.

Change how anonymous giving is tested

6efa3b8

public.json now returns "null" rather than "anonymous".

Make anon-user giving anonymous

92eb322

Oops.

Is 'null' null?

1b2d3af

Revert "Is 'null' null?"

6a8b1e7

This reverts commit 1b2d3af.

Revert "Change how anonymous giving is tested"

31f0c1d

This reverts commit 6efa3b8.

Comment out where I think the problem is

91bb247

Not sure what this line does, but making sure this is the kicker.

mattbk added 3 commits April 2, 2016 11:08

Revert "Merge pull request #118 from gratipay/trailing-zero"

066ba6c

This reverts commit c005194, reversing changes made to 3c0ddb3.

Revert "Revert "Merge pull request #118 from gratipay/trailing-zero""

089f7e2

This reverts commit 066ba6c.

Remove console log

8ed5153

Remove duplicate API call

8b7e0eb

chadwhitacre mentioned this pull request Apr 4, 2016

Radar 53 gratipay/inside.gratipay.com#558

Closed

chadwhitacre added 2 commits April 9, 2016 19:21

Convert tabs to spaces

8f24139

Revert newline changes

d497f26

chadwhitacre reviewed Apr 9, 2016
View reviewed changes

chadwhitacre mentioned this pull request Apr 20, 2016

Core Radar 55 gratipay/inside.gratipay.com#575

Closed

Merge remote-tracking branch 'refs/remotes/origin/master' into team-e…

7785ac2

…xperiments

mattbk added a commit that referenced this pull request Apr 22, 2016

Copy test changes from team-experiments branch

9d4d9c7

Based on discussion at #112 (comment). Breaking up that PR into more manageable chunks.

This was referenced Apr 22, 2016

Explain tests better #132

Merged

Widgets for Gratipay 2.0 #103

Closed

Merge branch 'team-experiments' of https://github.com/gratipay/grtp.co …

e41c3be

…into team-experiments

chadwhitacre pushed a commit that referenced this pull request Apr 27, 2016

Copy test changes from team-experiments branch

181299b

Based on discussion at #112 (comment). Breaking up that PR into more manageable chunks.

mattbk closed this May 13, 2016

mattbk removed the Review label May 13, 2016

mattbk mentioned this pull request Jun 19, 2016

add a Team receiving widget #138

Merged

5 tasks

mattbk mentioned this pull request Dec 28, 2016

widgets tab shows old widget example, should reference v2 js #155

Closed

chadwhitacre deleted the team-experiments branch December 28, 2016 16:33

chadwhitacre restored the team-experiments branch December 28, 2016 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Widgets work with both ~users and Teams #112

Widgets work with both ~users and Teams #112

mattbk commented Feb 7, 2016

chadwhitacre commented Feb 8, 2016

mattbk commented Feb 8, 2016

chadwhitacre commented Feb 8, 2016

mattbk commented Feb 8, 2016

mattbk commented Feb 9, 2016

mattbk commented Feb 10, 2016

mattbk commented Feb 10, 2016

mattbk commented Feb 11, 2016

chadwhitacre commented Feb 11, 2016

mattbk commented Feb 11, 2016

chadwhitacre commented Feb 11, 2016

mattbk commented Feb 11, 2016

mattbk commented Apr 2, 2016

mattbk commented Apr 2, 2016

aandis commented Apr 3, 2016

chadwhitacre Apr 9, 2016

mattbk Apr 10, 2016

chadwhitacre commented Apr 10, 2016

mattbk commented Apr 11, 2016

mattbk commented Apr 20, 2016

chadwhitacre commented Apr 20, 2016

mattbk commented Apr 20, 2016

mattbk commented May 13, 2016

Widgets work with both ~users and Teams #112

Widgets work with both ~users and Teams #112

Conversation

mattbk commented Feb 7, 2016

chadwhitacre commented Feb 8, 2016

mattbk commented Feb 8, 2016

chadwhitacre commented Feb 8, 2016

mattbk commented Feb 8, 2016

mattbk commented Feb 9, 2016

mattbk commented Feb 10, 2016

mattbk commented Feb 10, 2016

mattbk commented Feb 11, 2016

chadwhitacre commented Feb 11, 2016

mattbk commented Feb 11, 2016

chadwhitacre commented Feb 11, 2016

mattbk commented Feb 11, 2016

mattbk commented Apr 2, 2016

mattbk commented Apr 2, 2016

aandis commented Apr 3, 2016

chadwhitacre Apr 9, 2016

Choose a reason for hiding this comment

mattbk Apr 10, 2016

Choose a reason for hiding this comment

chadwhitacre commented Apr 10, 2016

mattbk commented Apr 11, 2016

mattbk commented Apr 20, 2016

chadwhitacre commented Apr 20, 2016

mattbk commented Apr 20, 2016

mattbk commented May 13, 2016