Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Wire up homepage form to hit JSON endpoint #4613

Merged
merged 13 commits into from
Sep 10, 2017
Merged

Wire up homepage form to hit JSON endpoint #4613

merged 13 commits into from
Sep 10, 2017

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Sep 8, 2017 •
edited
Loading

← #4617 — #4621 →

Todo

  • recover Braintree sandbox login (again!) so we can see the charge landing there and verify two-way cross-linking
  • finish getting charge to work -- need to update BRAINTREE_* envvars other than client authorization?
  • show success when there is success
  • either use parsed return values or don't send them (not sure we need them since the form is AJAX post so the fields are still filled)
  • undo hiding of optional promo section
  • show errors when there are errors → New homepage error handling #4618
  • test validation ttw → New homepage error handling #4618
  • hide "Who are you?" behind a gate → Rationalize how optional sections are treated #4609
  • change base to new-homepage

@chadwhitacre chadwhitacre changed the base branch from master to new-homepage-wireup September 8, 2017 22:19
This was referenced Sep 8, 2017
Closed
Merged
@chadwhitacre
Copy link
Contributor Author

🙀 😱 🎃 😮 😻 😍 🙉 💃

screen shot 2017-09-08 at 9 07 34 pm

@chadwhitacre
Copy link
Contributor Author

Squeeeeeeeeee!

screen shot 2017-09-08 at 10 34 42 pm

@chadwhitacre
Copy link
Contributor Author

ohyesohyesohyesohyesohyesohyes

screen shot 2017-09-09 at 8 28 51 am

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-09-09 at 8 29 48 am

@chadwhitacre
Copy link
Contributor Author

💃

screen shot 2017-09-09 at 1 47 29 pm

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-09-09 at 2 30 58 pm

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-09-09 at 3 05 31 pm

@chadwhitacre
Copy link
Contributor Author

Pushed a bunch of work, was 3e13478. Needs a lot of cleanup.

This was referenced Sep 9, 2017
Merged
Closed
Merged
@chadwhitacre
Copy link
Contributor Author

Rebased, was 92adbee.

@chadwhitacre chadwhitacre mentioned this pull request Sep 10, 2017
Merged
3 tasks
@chadwhitacre chadwhitacre changed the base branch from new-homepage-wireup to new-homepage-api-cleanups September 10, 2017 02:01
@chadwhitacre
Copy link
Contributor Author

Sending some todo items back to #4598.

@chadwhitacre chadwhitacre changed the title Wire up homepage form to hit API Wire up homepage form to hit JSON endpoint Sep 10, 2017
@chadwhitacre
Copy link
Contributor Author

Rebased, was c4db9b2.

@chadwhitacre
Copy link
Contributor Author

Hmm ... Travis failing ... Firefox issue?

@chadwhitacre chadwhitacre mentioned this pull request Sep 10, 2017
Merged
3 tasks
@chadwhitacre
Copy link
Contributor Author

Trying locally with Firefox ...

@chadwhitacre
Copy link
Contributor Author

Fails though differently. Debugging ...

@chadwhitacre
Copy link
Contributor Author

Extraneous issues locally, dropped back to esr to match CI.

@chadwhitacre
Copy link
Contributor Author

Ah! .type vs. .click cf. #4614 :o)

@chadwhitacre chadwhitacre mentioned this pull request Sep 10, 2017
Closed
@chadwhitacre
Copy link
Contributor Author

Green! 💃

@chadwhitacre chadwhitacre mentioned this pull request Sep 10, 2017
Merged
2 tasks
@chadwhitacre chadwhitacre changed the base branch from new-homepage-api-cleanups to new-homepage September 10, 2017 16:57
@chadwhitacre
Copy link
Contributor Author

🚨 Self-merge license 🚨

@chadwhitacre chadwhitacre merged commit f1fdd4b into new-homepage Sep 10, 2017
@chadwhitacre chadwhitacre deleted the new-homepage-js branch September 28, 2017 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chadwhitacre