Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Rationalize how optional sections are treated #4609

Closed
wants to merge 7 commits into from

Conversation

chadwhitacre
Copy link
Contributor

Part of #4598.

@chadwhitacre
Copy link
Contributor Author

@EdOverflow A couple things by way of functional review:

  • Let's blur the button so you don't end up with it focused after canceling.
  • The help text for the closed state is still there in the open state.

@chadwhitacre chadwhitacre force-pushed the new-homepage branch 2 times, most recently from f08f17f to 8594436 Compare September 10, 2017 08:32
@chadwhitacre chadwhitacre changed the title Add ability to cancel promotion details Rationalize how optional sections are treated Sep 10, 2017
@chadwhitacre
Copy link
Contributor Author

We are going to launch with two optional sections of the form, with more anticipated (#4610, #4612). Broadening this PR to be about rationalizing our UX for optional sections, and placing it on the critical path for #4598.

@chadwhitacre chadwhitacre mentioned this pull request Sep 10, 2017
@chadwhitacre
Copy link
Contributor Author

Actually, I don't have time to get to this. Bumping to later.

@chadwhitacre
Copy link
Contributor Author

slack

@chadwhitacre
Copy link
Contributor Author

Closing for now, don't need this for gratipay/inside.gratipay.com#1160.

@chadwhitacre chadwhitacre deleted the new-homepage-cancel-promotion branch September 27, 2017 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants