Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Add sign-in modal #4525

Merged
merged 7 commits into from
Jun 26, 2017
Merged

Add sign-in modal #4525

merged 7 commits into from
Jun 26, 2017

Conversation

rohitpaulk
Copy link
Contributor

@rohitpaulk rohitpaulk commented Jun 19, 2017

Part of #1052

Screenshots:

gratipay-sign-in

@rohitpaulk rohitpaulk force-pushed the add-sign-in-modal branch 4 times, most recently from 2f17cfc to 024624d Compare June 19, 2017 09:15
@chadwhitacre
Copy link
Contributor

Sentry has an awesome blur effect on the background when the modal is up. Don't have a screenshot handy but will keep an eye out ...

@rohitpaulk
Copy link
Contributor Author

We should also open the modal automatically on a 401 page...

@rohitpaulk
Copy link
Contributor Author

We should also open the modal automatically on a 401 page...

Done in 985296e

@rohitpaulk
Copy link
Contributor Author

Going to deploy to staging..

@rohitpaulk
Copy link
Contributor Author

Deployed to staging. Actual signing in/up won't work because we haven't configured Github properly, but the modal should work.

401 page: http://gratipay-staging.herokuapp.com/about/me/emails
Homepage: http://gratipay-staging.herokuapp.com/

@mattbk
Copy link
Contributor

mattbk commented Jun 21, 2017

Works for me and passes tests locally.

@mattbk
Copy link
Contributor

mattbk commented Jun 21, 2017

Why do we want this again?

@rohitpaulk
Copy link
Contributor Author

@mattbk This was extracted out of #1052. #1052 (comment) for reference

@rohitpaulk
Copy link
Contributor Author

(Added that to the PR description too)

@mattbk
Copy link
Contributor

mattbk commented Jun 21, 2017

Gotcha. I thought I remembered something like that.

@chadwhitacre
Copy link
Contributor

!m @rohitpaulk

So I think I am going to adopt a really low-bar code review strategy for the next month or two while I'm traveling, in order to not slow down our shipping. Basically, I'm going to skim looking for dangerous (i.e., security-related) blunders. Beyond that I'm not going to worry much about architecture, etc. You okay with that @rohitpaulk et al.?

@mattbk Will you have bandwidth this summer to handle functional review?

@mattbk
Copy link
Contributor

mattbk commented Jun 21, 2017

Probably.

@chadwhitacre
Copy link
Contributor

@mattbk Awesome, in that case let me know when this is good from a UX/functional point of view and I will skim the code again and merge. :-)

@mattbk mattbk requested review from mattbk and removed request for mattbk June 22, 2017 14:31
@mattbk
Copy link
Contributor

mattbk commented Jun 22, 2017

It works for me and looks fine.

@chadwhitacre chadwhitacre changed the base branch from extract-modal to master June 24, 2017 19:35
@chadwhitacre
Copy link
Contributor

Rebased, was 985296e.

@rohitpaulk
Copy link
Contributor Author

@whit537 Have you had a look at this yet?

@chadwhitacre chadwhitacre merged commit bd4b1a7 into master Jun 26, 2017
@chadwhitacre chadwhitacre deleted the add-sign-in-modal branch June 26, 2017 15:19
@chadwhitacre
Copy link
Contributor

@rohitpaulk Yes! Just ran out of time on the road the other day. ☺️

@rohitpaulk
Copy link
Contributor Author

!m @whit537

I'm turning the staging app off.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants