This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Extract a modal component #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
force-pushed
the
extract-modal
branch
from
2605f9b
to
687956c
Compare
|
Screenshots: Desktop - Before
Desktop - After
Mobile - Before
Mobile - After
|
rohitpaulk
force-pushed
the
extract-modal
branch
2 times, most recently
from
a0cb411
to
43ac69f
Compare
|
I can only assume this works, because #4525 works. |
chadwhitacre
force-pushed
the
extract-modal
branch
from
43ac69f
to
c45e1b9
Compare
|
Rebased, was 43ac69f. |
|
Ready to merge when green ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #1052 (comment). This seems like a good enough chunk to review, hence split into a separate PR.