Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix nmasspays check during payday #4360

Merged
merged 3 commits into from
Mar 16, 2017
Merged

Fix nmasspays check during payday #4360

merged 3 commits into from
Mar 16, 2017

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Mar 2, 2017

@chadwhitacre
Copy link
Contributor Author

Actually, withdrawing from review until I can update nmasspays as well.

@chadwhitacre chadwhitacre changed the title Fix requests API usage Fix nmasspays check during payday Mar 2, 2017
@chadwhitacre
Copy link
Contributor Author

Blorg. Just noticed that exchanges don't have a payday link (that's only transfers).

@chadwhitacre
Copy link
Contributor Author

Lol, this test suite passes because it doesn't actually assert anything. 💩

@chadwhitacre
Copy link
Contributor Author

Alright, ready for review now, @nobodxbodon @rohitpaulk et al.

@chadwhitacre
Copy link
Contributor Author

Bump.

@chadwhitacre
Copy link
Contributor Author

Rebased, was d5c8181.

@chadwhitacre chadwhitacre force-pushed the fix-nmasspay-read branch 2 times, most recently from c2f260f to b9b807f Compare March 9, 2017 14:40
@chadwhitacre
Copy link
Contributor Author

How about this one, @mattbk?

@chadwhitacre
Copy link
Contributor Author

I don't know why this is saying "out-of-date." 😕

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Mar 15, 2017

Hrm ... now it's not. ¯\_(ツ)_/¯

@mattbk
Copy link
Contributor

mattbk commented Mar 15, 2017

I'm not sure how to review this one.

@chadwhitacre
Copy link
Contributor Author

Okay. I may self-merge this as well to keep things going.

@mattbk
Copy link
Contributor

mattbk commented Mar 16, 2017

Okay. I may self-merge this as well to keep things going.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants