This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
restructure About docs #3068
Merged
restructure About docs #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm porting the tip distribution charts to the same library we're using for the main charts, so that I can fold the charts page into the stats page. This is part of an overall rationalization of the information architecture under /about/. As part of this I'm switching to bins that make sense to humans, based on 1s, 2s, and 5s. The next step is to generalize gratipay/charts.js to work with a non-temporal X axis.
Removes the dependency on d3.
Preserves existing behavior. tip-distribution.json isn't documented API so I think we're okay to change it.
This PR includes #3067. |
@whit537 You still awake, you forgot to move this to "review" |
This PR has removed the Fraud page, and thus the only link to the Delpan incident page. |
@Changaco Yeah, we haven't ended up making more incident reports like that, so I decided to take it out of the main navigation of the site. I left the direct URL the same though, and we do link there from our blog post about Delpan. In the future I would expect us to publish similar incident reports on our blog rather than on a dedicated section of the site. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While wrestling with #3063 I found the IA on About to be muddy, so I'm cleaning that up in a separate PR.