fold charts into stats #3067
fold charts into stats #3067
Conversation
|
Ready for review. This PR incorporates #3064, so you can review/merge that first if you want to. |
|
@whit537 We have some failing tests here. After that I'll merge. |
|
@clone1018 Working on the last one ... |
|
Note that this is actually a breaking API change because it changes the sort order of charts.json. We gonna care about that? |
I'm porting the tip distribution charts to the same library we're using for the main charts, so that I can fold the charts page into the stats page. This is part of an overall rationalization of the information architecture under /about/. As part of this I'm switching to bins that make sense to humans, based on 1s, 2s, and 5s. The next step is to generalize gratipay/charts.js to work with a non-temporal X axis.
Removes the dependency on d3.
chadwhitacre
force-pushed
the
fold-charts
branch
from
67fc8b7
to
f8b0765
Compare
|
Rebased on master. |
Preserves existing behavior. tip-distribution.json isn't documented API so I think we're okay to change it.
|
Okay, really ready for review now. :-) |
|
We decided we were hesitant on merging this because there are potential users of it. Can we rename the json endpoint for now, keeping the old one intact and then we'll get this merged in. |
|
The new tip distribution charts look terrible, and I'm not convinced that writing our own code instead of using d3 is a good idea. |
|
The code is already written though @Changaco. Also how does the chart look terrible? Is it the data or the actual design of the chart? |
Fixes #2740, and starts to simplify the IA of /about/, which is necessary to further rationalize our navigation following #2938 (see #3063).