Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the onSchemaChange prop #2541

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix the onSchemaChange prop #2541

merged 1 commit into from
Jul 5, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

Fixes #2503

This broke when we introduced the SchemaContextProvider from @graphiql/react in v1.9.3 (see #2420)

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2022

🦋 Changeset detected

Latest commit: 900fd2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphiql Patch
@graphiql/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2541 (900fd2c) into main (2d91916) will increase coverage by 3.75%.
The diff coverage is 23.64%.

@@            Coverage Diff             @@
##             main    #2541      +/-   ##
==========================================
+ Coverage   65.70%   69.45%   +3.75%     
==========================================
  Files          85       71      -14     
  Lines        5106     4155     -951     
  Branches     1631     1375     -256     
==========================================
- Hits         3355     2886     -469     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d0437...900fd2c. Read the comment docs.

@thomasheyenbrock thomasheyenbrock merged commit 788d84e into main Jul 5, 2022
@thomasheyenbrock thomasheyenbrock deleted the issues/2503 branch July 5, 2022 13:46
@acao acao mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onSchemaChange callback not triggered
1 participant