-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SchemaContext
to @graphiql/react
#2420
Conversation
🦋 Changeset detectedLatest commit: 65048ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
+ Coverage 65.70% 69.05% +3.34%
==========================================
Files 85 71 -14
Lines 5106 4498 -608
Branches 1631 1490 -141
==========================================
- Hits 3355 3106 -249
+ Misses 1747 1388 -359
Partials 4 4
Continue to review full report at Codecov.
|
e817f50
to
903dbb7
Compare
adf2989
to
663f818
Compare
Wouldn't this even potentially fit into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@timsuchanek it would seem that way, but react context is still react specific. I was thinking that if we move the state to something like zustand or xstate eventually, then we would have a js framework agnostic state implementation for toolkit. But this should be fine for now. In vue they might use vuex, and sveltekit for svelte, so state manager implementations have become quite framework specific anyways |
903dbb7
to
52afc40
Compare
663f818
to
65048ff
Compare
The latest changes of this PR are not available as canary, since there are no linked |
Another rather big PR: Moving over the logic for fetching and validating the schema into a new context in
@graphiql/react
.We still keep the
schema
insideGraphiQL
state for now so that deriving operation facts can continue to work like before. Moving this logic over is next!