Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show proper error when headers or variables are invalid json #2463

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

I messed this up in #2453 (which is not published yet), there is no global try-catch anymore, so we need to avoid throwing early.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

⚠️ No Changeset found

Latest commit: 7ae2d5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #2463 (7ae2d5f) into main (2d91916) will increase coverage by 3.40%.
The diff coverage is 57.45%.

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   65.70%   69.11%   +3.40%     
==========================================
  Files          85       71      -14     
  Lines        5106     4190     -916     
  Branches     1631     1402     -229     
==========================================
- Hits         3355     2896     -459     
+ Misses       1747     1290     -457     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53bec6...7ae2d5f. Read the comment docs.

@thomasheyenbrock thomasheyenbrock merged commit 7f542e7 into main Jun 1, 2022
@thomasheyenbrock thomasheyenbrock deleted the fix/invalid-variables-or-headers branch June 1, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants