Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add execution context to @graphiql/react #2453

Merged
merged 1 commit into from
May 31, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

This new context is used for executing operations. It will read the current query, variables and headers from the respective editors and write the response in the read-only response editor.

We don't need to pass the onRunQuery prop to the editor components anymore, the editor hooks are now internally calling the run function from the new context.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 3bdff89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/react Minor
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thomasheyenbrock thomasheyenbrock force-pushed the feat/execution-context branch from ced3f6e to c5d5f3e Compare May 30, 2022 11:36
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2453 (3bdff89) into main (2d91916) will increase coverage by 3.16%.
The diff coverage is 56.41%.

@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
+ Coverage   65.70%   68.86%   +3.16%     
==========================================
  Files          85       71      -14     
  Lines        5106     4211     -895     
  Branches     1631     1411     -220     
==========================================
- Hits         3355     2900     -455     
+ Misses       1747     1307     -440     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0fd8b...3bdff89. Read the comment docs.

@thomasheyenbrock thomasheyenbrock force-pushed the feat/execution-context branch from c5d5f3e to 024cd24 Compare May 30, 2022 12:27
Base automatically changed from feat/tabs-context to main May 31, 2022 07:49
@thomasheyenbrock thomasheyenbrock force-pushed the feat/execution-context branch from 024cd24 to 3bdff89 Compare May 31, 2022 07:51
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@thomasheyenbrock thomasheyenbrock merged commit 1b41e33 into main May 31, 2022
@thomasheyenbrock thomasheyenbrock deleted the feat/execution-context branch May 31, 2022 08:03
@acao acao mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants