Upgrade dependencies to fix build breakages #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had some lint-related build failures: https://travis-ci.org/graphql/graphiql/builds/181453346 lately. Unfortunately, these masked test failures introduced by 35d8d38. When we fixed the lint (1eeb36c), the test failures showed up: https://travis-ci.org/graphql/graphiql/builds/182431531 This commit fixes that by upgrading our deps: - Replace "react-addons-test-utils", which access a path that doesn't exist in current "react-dom", with "react-test-renderer". This required some API updates in the tests, but also some changes to use ref-based DOM node access rather than `ReactDOM.findDOMNode`, which doesn't work in "react-test-renderer". See: - facebook/react#7371 - facebook/react#8324 > Yea sorry, refs can work but `findDOMNode()` can't (we tried).
|
Test plan: updated a small app I have to use this build (with |
asiandrummer
reviewed
Dec 9, 2016
| @@ -20,7 +17,7 @@ export default class CodeMirrorSizer { | |||
|
|
|||
| updateSizes(components) { | |||
| components.forEach((component, i) => { | |||
| const size = ReactDOM.findDOMNode(component).clientHeight; | |||
| const size = component.getClientHeight(); | |||
There was a problem hiding this comment.
Could you check if DocExplorer also needs to expose this method?
There was a problem hiding this comment.
I don't think so. Only used from these.
This was referenced Dec 9, 2016
Merged
acao
pushed a commit
to acao/graphiql
that referenced
this pull request
Jun 5, 2019
* Updated dependencies & released version v1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some lint-related build failures lately. Unfortunately, these masked test failures introduced by 35d8d38. When we fixed the lint (1eeb36c), the test failures showed up.
This commit fixes that by upgrading our deps:
This required some API updates in the tests, but also some changes to use ref-based DOM node access rather than
ReactDOM.findDOMNode, which doesn't work in "react-test-renderer".See: