Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DocExplorer into smaller files #243

Merged
merged 7 commits into from
Dec 10, 2016
Merged

Split DocExplorer into smaller files #243

merged 7 commits into from
Dec 10, 2016

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Dec 9, 2016

Just to make things easier to find: rather than thinking "where does the search box live?" I can just type "search" into my editor's fuzzy finder and go straight to the component.

@asiandrummer
Copy link
Contributor

:D Thanks @wincent! I'm taking a closer look now but I'm pretty sure this is fine as it is.

Copy link
Contributor

@asiandrummer asiandrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@asiandrummer asiandrummer merged commit f45fbde into graphql:master Dec 10, 2016
@wincent wincent deleted the glh/split-components-pr branch December 15, 2016 00:31
acao pushed a commit to acao/graphiql that referenced this pull request Jun 5, 2019
add test case for language service hover
acao pushed a commit that referenced this pull request Feb 20, 2022
Derived from github.com/kumarharsh/graphql-for-vscode@22d83155524a8c5b3c32d2ba5024d4882070fc69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants