This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
forked from yandooo/graphql-spring-boot
-
Notifications
You must be signed in to change notification settings - Fork 325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice! What do you think about the |
Those example projects are on my list too, to move them into the samples repo. |
…rter-reorganization
Unit Test Results 88 files 88 suites 43s ⏱️ Results for commit 4703014. ♻️ This comment has been updated with latest results. |
# Conflicts: # .github/workflows/pull-request.yml
SonarCloud Quality Gate failed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work on consolidating all starters into one module as suggested in #516.
Schema strategy
The library supports two strategies:
tools
andannotations
. By default thetools
strategy is enabled in this approach. You can switch toannotations
by setting the property:Is there a better/alternative way on automatically selecting the right strategy to use based on available beans or other configurations on the class path? Are certain properties for
annotations
required for example and could we therefore enable it automatically if we see that one or all of those required parameters have been provided?Web application type
There's just one
graphql-spring-boot-starter
now and it no longer pulls in the relatedspring-boot-starter-web
orspring-boot-starter-webflux
packages anymore. Instead users are now required to explicitly include one of those starters themselves to define which web application type to start up. The starters are now configured to keep that web application type in mind and only configure elements that are compatible with that type.Editors
Moved all editor starters inside the main starter and introduced
enabled
properties to enable them. All properties have been moved inside thegraphql
group, e.g.