Backport of 868a8b4f to 0.9.x - Optionally specify fixed 'now' to fetch #80
Conversation
|
This fixes graphite-project/graphite-web#597 |
|
@esc this PR actually fixes the issue of the 0.9.x branch of graphite-web requiring the master branch of whisper that you just mentioned in graphite-project/graphite-web#677 . |
|
@obfuscurity are you able to take care of merging this please? I see you merged this same change into master so would probably be the best one to do it. |
|
@steve-dave I can also handle merging. Is it possible to add some tests here? |
|
@esc I can look into a test tomorrow but keep in mind it's a clean cherry-pick of a commit that's already in master. I tagged @obfuscurity as they merged the original commit into whisper/master and the PR on graphite-web/0.9.x graphite-project/graphite-web#523 that requires it so figured they would know more about it than you or I. |
Backport of 868a8b4 to 0.9.x - Optionally specify fixed 'now' to fetch
|
Thanks @steve-dave, I'll be looking through your PRs and trying to merge what I'm able to tonight. We (graphite maintainers who don't have a lot of free time) really appreciated the work you've put in to make graphite better. |
|
@SEJeff thanks for finding the time, I really appreciate it! |
|
@steve-dave test will still be appreciated, if you find the time. 😄 |
|
Does this mean, we can release a new whisper from |
|
@esc I believe we could, and perhaps should, have a release of all of carbon, whisper and graphite-web together... unless that was a rhetorical question? Also, yes, I still have testing this on my list. |
This backport is required for the 0.9.x branch of graphite-web to be compatible with the 0.9.x branch of carbon.