Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix RTD builds for 0.9.x #1370

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Trying to fix RTD builds for 0.9.x #1370

merged 1 commit into from
Oct 26, 2015

Conversation

deniszh
Copy link
Member

@deniszh deniszh commented Oct 25, 2015

Please see #677 (comment)

@deniszh
Copy link
Member Author

deniszh commented Oct 26, 2015

@obfuscurity @gwaldo @brutasse - could you please check - does it looks good and does it fix RTD build (merge/revert maybe) ?

@brutasse
Copy link
Member

@deniszh great, I forgot that setup.cfg didn't have the [install] section anymore in master. Looks good, there's only a try/finally block missing around the setup() call: see what's done in master, we need to make sure the add/remove dance doesn't alter the file.

@deniszh
Copy link
Member Author

deniszh commented Oct 26, 2015

Now looks better, @brutasse ?

@brutasse
Copy link
Member

@deniszh 👍

brutasse added a commit that referenced this pull request Oct 26, 2015
Trying to fix RTD builds for 0.9.x
@brutasse brutasse merged commit a52c3c8 into graphite-project:0.9.x Oct 26, 2015
@brutasse
Copy link
Member

Build passed. Thanks @deniszh! ✨ ⚡

@deniszh deniszh deleted the 0.9.x_rtd_fix branch October 26, 2015 11:00
@deniszh
Copy link
Member Author

deniszh commented Oct 26, 2015

Cool! We are ready to finally "push the button"
push

@JeanFred
Copy link
Member

This is beautiful. Great job @deniszh

@obfuscurity
Copy link
Member

Indeed, great work @deniszh @brutasse. Nice to have this fixed (for a while anyways, lol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants