Allow Registering specifc ServiceEntries #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A usage example can be found in https://github.com/metalkube/mdns-publisher/blob/master/pkg/publisher/publisher.go#L32 |
This patch allows the library user more control in the registry flow by giving them the chance to pass the ServiceEntries they crafted.
celebdor
force-pushed
the
register-svc-entry
branch
from
ad6f6e1
to
0a73850
Compare
grandcat
requested changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the library user more control in the registry flow by
giving them the chance to pass the ServiceEntries they crafted.