Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RegisterServiceEntry function #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliverpool
Copy link

Following #52 (which seems stale), this adds a RegisterServiceEntry function.

What's the benefit over Register?

To be able to override specific fields of the ServiceEntry (the HostName for instance, without having to provide ips).

Given there should be an extended API, code should be reused rather than duplicated.

I refactored the Register and RegisterProxy to use this new method.

Also, test coverage should be added.

I have added some basic tests, to check that the fields are properly set.

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant