-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify import #834
Simplify import #834
Conversation
🚀 Deployed on https://649b4b789506ac0888cea751--grammy.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hmm seems like there is nothing to do here. The imports were already replaced to deno.land/x in main. |
Perhaps we should do the same for Vercel? |
Convert to deno.land/x import or just grammy? |
I was thinking of using |
What is the new deno-based service by vercel? |
Oh that makes sense |
I’ll leave that decision to our VP of Serverless, @PonomareVlad. |
|
Thanks! |
What are your thoughts on #834 (comment), @PonomareVlad? |
|
What about their Edge Runtime? #834 (comment) |
Earlier I think about extending Vercel guide for Edge Runtime case, but we need to test which grammY plugins still incompatible with it and notify about this before announcing compatibility 🌚 |
So you mean the |
Is identical to |
So it’ll be fine for Vercel, right? |
Including Vercel, right |
Can you create a PQ for that? |
Yes, but it depends on:
|
I meant for the Node.js example, not their edge runtime. |
In docs or in repo with examples ? |
As we tested earlier, the
"browser"
target in the"exports"
field is already supported by Vercel Edge and Cloudflare WorkersI suggest shortening the optional import from the
web
path to get more generic examplesExample source