Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify import #834

Closed
wants to merge 3 commits into from
Closed

Conversation

PonomareVlad
Copy link
Member

@PonomareVlad PonomareVlad commented Jun 27, 2023

As we tested earlier, the "browser" target in the "exports" field is already supported by Vercel Edge and Cloudflare Workers

I suggest shortening the optional import from the web path to get more generic examples

Example source

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 20:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 20:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 20:46 Inactive
@PonomareVlad PonomareVlad marked this pull request as ready for review June 27, 2023 20:48
@github-actions github-actions bot temporarily deployed to pull request June 27, 2023 20:50 Inactive
@rojvv rojvv changed the title Reducing import from web path for Cloudflare Workers following #441 Simplify import Oct 14, 2023
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

Hmm seems like there is nothing to do here. The imports were already replaced to deno.land/x in main.

@rojvv rojvv closed this Oct 14, 2023
@KnorpelSenf KnorpelSenf deleted the reducing-web-import-for-cloudflare-workers branch October 14, 2023 10:14
@KnorpelSenf
Copy link
Member

Perhaps we should do the same for Vercel?

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

Convert to deno.land/x import or just grammy?

@KnorpelSenf
Copy link
Member

I was thinking of using grammy instead of grammy/web but now that you ask about it, we might actually migrate the guides to the new deno-based service by vercel, right?

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

What is the new deno-based service by vercel?

@KnorpelSenf
Copy link
Member

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

Oh that makes sense

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

I’ll leave that decision to our VP of Serverless, @PonomareVlad.

@PonomareVlad PonomareVlad mentioned this pull request Oct 14, 2023
@PonomareVlad
Copy link
Member Author

Hmm seems like there is nothing to do here. The imports were already replaced to deno.land/x in main.

@roj1512 There is to do

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

Thanks!

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

What are your thoughts on #834 (comment), @PonomareVlad?

@PonomareVlad
Copy link
Member Author

PonomareVlad commented Oct 14, 2023

What are your thoughts on #834 (comment), @PonomareVlad?

There is no any Deno-based service in Vercel 🌚

@PonomareVlad
Copy link
Member Author

PonomareVlad commented Oct 14, 2023

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

What about their Edge Runtime? #834 (comment)

@PonomareVlad
Copy link
Member Author

PonomareVlad commented Oct 14, 2023

What about their Edge Runtime? #834 (comment)

Earlier I think about extending Vercel guide for Edge Runtime case, but we need to test which grammY plugins still incompatible with it and notify about this before announcing compatibility 🌚

For example

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

So you mean the grammy import is better for now, right?

@PonomareVlad
Copy link
Member Author

PonomareVlad commented Oct 14, 2023

So you mean the grammy import is better for now, right?

Is identical to grammy/web for supported runtimes that understand browser exports

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

So it’ll be fine for Vercel, right?

@PonomareVlad
Copy link
Member Author

So it’ll be fine for Vercel, right?

Including Vercel, right

@rojvv
Copy link
Member

rojvv commented Oct 14, 2023

Can you create a PQ for that?

@PonomareVlad
Copy link
Member Author

Yes, but it depends on:

What about their Edge Runtime? #834 (comment)

Earlier I think about extending Vercel guide for Edge Runtime case, but we need to test which grammY plugins still incompatible with it and notify about this before announcing compatibility 🌚

For example

@rojvv
Copy link
Member

rojvv commented Oct 15, 2023

I meant for the Node.js example, not their edge runtime.

@PonomareVlad
Copy link
Member Author

I meant for the Node.js example, not their edge runtime.

In docs or in repo with examples ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants