Web bundle concept

[PonomareVlad]

Is this the right direction, or need something different ? 🌚

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (3124f1f) 95.83% compared to head (723482e) 95.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           4        4           
  Lines         840      840           
  Branches      124      124           
=======================================
  Hits          805      805           
  Misses         33       33           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[KnorpelSenf]

In general, this is the right approach in the sense that this setup will create the correct build artefacts.

However, it has been a long standing problem that we used 30 copies of a slightly varying build setup across all repositories. Initially, the idea behind this was that each plugin could be maintained by a different person, so they should all have complete freedom over their setup. However, this turned out to be different in reality. Now, a handful of people all maintain several plugins each, and they communicate a lot so it's sort of like a small, integrated team. In such a world, it's rather annoying to have to remember and sync up changes between many repos. (Example: There were many PQs necessary to change the encoding option in TS config files.)

Therefore, ideally, we would want to extract the build config from the core repo and put it in a central place. All plugins could then rely on this shared setup, which would help us prevent the replication introduced in this PQ many times across many repos. We first need to work on wojpawlik/deno2node#40 and then create a new repo with a generic build script.

Since we still want to allow customisation of this setup in specific repos, we may want to export the build steps as functions from the common build script.

[wojpawlik]

You can already use deno2node API to write a shared build script. I'm happy to help :)

TypeScript expects tsconfig.json to be a local file, and it uses it to resolve source files.

[KnorpelSenf]

We want to share the config between projects, and resolve files via script args

[wojpawlik]

The API doesn't even require tsconfig.json:

const ctx = new Context({ compilerOptions });
ctx.project.addSourceFilesAtPaths(...);

and then https://github.com/fromdeno/deno2node/blob/1461bd6e634ee3953545c4ce7823c4b024dc0793/src/cli.ts#L37-L46.

[wojpawlik]

Consider setting cache root within grammY's script, and re-using it here to avoid duplication:

Suggested change

	"bundle-web": "mkdir -p out deno_cache && cd bundling && DENO_DIR=$PWD/../deno_cache deno run --unstable --quiet --allow-net --allow-read --allow-env=DENO_DIR,XDG_CACHE_HOME,HOME,DENO_AUTH_TOKENS --allow-write=../out,$PWD/../deno_cache bundle-web.ts dev ../src/mod.ts",
	"bundle-web": "mkdir -p out deno_cache && cd bundling && deno run --unstable --quiet --allow-net --allow-read=.. --allow-write=../out,../deno_cache https://raw.githubusercontent.com/grammyjs/grammY/v1.17.2/bundling/bundle-web.ts dev ../src/mod.ts",

[wojpawlik]

I don't know how to prevent bundling entire grammY in.

Isn't the Node build of conversations web compatible already?

[PonomareVlad]

Isn't the Node build of conversations web compatible already?

No, because oson depends on @deno/shim-deno package that imports node-specific fs apis

[wojpawlik]

https://github.com/KnorpelSenf/oson/blob/0fe5862fbb67181b902c5f2b1d50979079f0a369/build.ts#L22 can be removed @KnorpelSenf (KnorpelSenf/oson#7)

[PonomareVlad]

@wojpawlik https://t.me/grammyjs/149613

[KnorpelSenf]

We are going to:

1. Create a Deno script that uses d2n and can build everything (npm package and web build)
2. Unify the build and CI setup across the entire organisation with that script
3. Pass in everything as arguments, so that the build output no longer depends on config files in the respective repo

I don't really know yet when this will happen, but once it does, it will supersede this.

[PonomareVlad]

If someone is looking for a way to solve the problem of running the conversations plugin in the Vercel Edge environment, it is:

{
  "dependencies": {
    "@grammyjs/conversations": "^1.1.2"
  },
  "overrides": {
    "o-son": "npm:@ponomarevlad/[email protected]"
  }
}

Full example