Add grails-plugin-events to grails-dependencies
#13723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the Events plugin to all Grails applications by adding it to the `grails-dependencies`. Previously this has happened transitively through the inclusion of the Async plugin in `grails-dependencies`. However, as `grails-plugin-async` does not depend on the `grails-plugin-events`, it makes more sense to add `grails-plugin-events` in `grails-dependencies` explicitly. This prepares for the removal of `grails-plugins-events` to be declared as a dependency in `grails-plugin-async`. Related: grails/grails-async#44 grails/grails-async#69 grails/grails-async#70 #13324
These exclusions should not be necessary anymore as `javax:javaee-web-api` is not included in `grails-plugin-async` or `grails-gsp`.
matrei
added a commit
to grails/grails-async
that referenced
this pull request
Oct 3, 2024
`grails-plugin-events` is not a dependency of `grails-plugin-async`. Related: grails/grails-core#13723
jamesfredley
approved these changes
Oct 3, 2024
jdaugherty
approved these changes
Oct 3, 2024
matrei
added a commit
to grails/grails-async
that referenced
this pull request
Oct 4, 2024
`grails-plugin-events` is not a dependency of `grails-plugin-async`. Related: grails/grails-core#13723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Events plugin to all Grails applications by adding it to the
grails-dependencies.Previously this has happened transitively through the inclusion of the Async plugin in
grails-dependencies.However, as
grails-plugin-asyncdoes not actually depend ongrails-plugin-events, it makes more sense to addgrails-plugin-eventsingrails-dependenciesexplicitly.This prepares for the removal of
grails-plugins-eventsto be declared as a dependency ofgrails-plugin-async.Related:
grails/grails-async#44
grails/grails-async#69
grails/grails-async#70
#13324
This PR also removes the exclusion of
javax:javaee-web-apifromgrails-plugin-asyncandgrails-gspingrails-dependenciesasjavax:javaee-web-apiis not included in these modules.