Revert removal of deprecated grails-events-compat #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5e36db.
It's name was previously a sub-path of other groovy modules
guillermocalvo
approved these changes
Dec 21, 2023
matrei
added a commit
to grails/grails-core
that referenced
this pull request
Oct 3, 2024
This commit adds the Events plugin to all Grails applications by adding it to the `grails-dependencies`. Previously this has happened transitively through the inclusion of the Async plugin in `grails-dependencies`. However, as `grails-plugin-async` does not depend on the `grails-plugin-events`, it makes more sense to add `grails-plugin-events` in `grails-dependencies` explicitly. This prepares for the removal of `grails-plugins-events` to be declared as a dependency in `grails-plugin-async`. Related: grails/grails-async#44 grails/grails-async#69 grails/grails-async#70 #13324
matrei
added a commit
to grails/grails-core
that referenced
this pull request
Oct 3, 2024
* fix: Add `grails-plugin-events` to `grails-dependencies` This commit adds the Events plugin to all Grails applications by adding it to the `grails-dependencies`. Previously this has happened transitively through the inclusion of the Async plugin in `grails-dependencies`. However, as `grails-plugin-async` does not depend on the `grails-plugin-events`, it makes more sense to add `grails-plugin-events` in `grails-dependencies` explicitly. This prepares for the removal of `grails-plugins-events` to be declared as a dependency in `grails-plugin-async`. Related: grails/grails-async#44 grails/grails-async#69 grails/grails-async#70 #13324 * fix: Remove unnecessary exclusions of `javax:javaee-web-api` These exclusions should not be necessary anymore as `javax:javaee-web-api` is not included in `grails-plugin-async` or `grails-gsp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve grails/grails-core#13324