Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go modules #591

Merged
merged 8 commits into from Dec 8, 2020
Merged

Use go modules #591

merged 8 commits into from Dec 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2020

Dep has been deprecated as of September golang/go#38158 (comment) 2020. This PR removes dep and switches the project to use Go modules.

@ghost ghost mentioned this pull request Dec 3, 2020
@ooq
Copy link
Contributor

ooq commented Dec 4, 2020

Thanks for cleaning this up! Can you fix the travis test, I think it's complaining because some vendor script is missing after the update: https://travis-ci.org/github/grafeas/kritis/builds/747482496

@ooq
Copy link
Contributor

ooq commented Dec 7, 2020

Looks like it's still failing :( @cjones-shopify

@ghost
Copy link
Author

ghost commented Dec 8, 2020

The Travis-CI pipeline takes quite a long time to run, I'm sorry it's taken so long for me to fix this PR! :<

@ooq
Copy link
Contributor

ooq commented Dec 8, 2020

No worries, @cjones-shopify! I've recently noticed that Travis might not pass back the build status back -- not sure why. I'll check when this rerun finishes.

@ooq
Copy link
Contributor

ooq commented Dec 8, 2020

Looks like it's being queued forever :(

@ooq
Copy link
Contributor

ooq commented Dec 8, 2020

Hi just a quick update that the travis issue seems common due to their migration phase from travis-ci.org to travis-ci.com. I just fixed it by completing the migration.
The test looks good now (the Travis CI - Pull Request check) and you can ignore the continuous-integration/travis-ci/pr check.
Sorry for the confusion!

@ooq ooq merged commit fb62f65 into grafeas:master Dec 8, 2020
@ghost ghost deleted the use-go-modules branch December 8, 2020 17:01
@ghost
Copy link
Author

ghost commented Dec 8, 2020

Thank you so much @ooq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant