Update to k8s v1.16 #590
Closed
Update to k8s v1.16 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing branch as Go mod won't let me use v0.16.15, so the branch name is inaccurate. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to update Kritis to work with Kubernetes v1.16 (though apparently go modules likes v1.18 just as much!)
There's a few things that I'm uncertain about:
k8s.io/apimachinery/pkg/watch.Untilinpkg/kritis/kubernetes/wait.go. I've replicated what I believe should be identical functionality but I'm relatively new to this part of the Kubernetes API.Note that this PR includes changes from PR #591, hence the size of it. You can ignore the first two commits (50948e5, 22bdf0c). If the other PR is merged, I will rebase this PR on-top of
masterso it's easier to read.