JWK import/export for the ECDH & ECDSA #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
force-pushed
the
feat/ecdh-ecdsa-jwk
branch
from
bbadb1b to
9937385
Compare
olegbespalov
requested review from
mstoykov and
oleiade
and removed request for
a team
olegbespalov
force-pushed
the
feat/ecdsa
branch
from
b965aca to
6ca2bdd
Compare
olegbespalov
force-pushed
the
feat/ecdh-ecdsa-jwk
branch
from
9937385 to
15cdab3
Compare
olegbespalov
force-pushed
the
feat/ecdh-ecdsa-jwk
branch
from
15cdab3 to
d002f0a
Compare
mstoykov
approved these changes
Apr 17, 2024
oleiade
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR supports the JWK format for the ECDH and ECDSA.
It also migrates existing JWK usages from the third party (github.com/lestrrat-go/jwx) to SDK usage only.
Note: Initially, I had different commits for the EC JWK and Symmetric JWK, but unfortunately, I squashed them 😢
Hopefully, that's still fine, keeping in mind the size of the PR.
Based on: #69
Why?