ECDSA support #69
Merged
ECDSA support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
force-pushed
the
feat/ecdsa
branch
2 times, most recently
from
3851c78 to
a8aa30e
Compare
olegbespalov
force-pushed
the
feat/ecdh
branch
2 times, most recently
from
a15ebeb to
cb23f63
Compare
Merged
olegbespalov
force-pushed
the
feat/ecdsa
branch
from
a8aa30e to
4566430
Compare
olegbespalov
requested review from
mstoykov and
oleiade
and removed request for
a team
olegbespalov
force-pushed
the
feat/ecdsa
branch
from
4566430 to
b965aca
Compare
mstoykov
requested changes
Apr 17, 2024
Comment on lines
+37
to
+49
| const string2ArrayBuffer = (str) => { | ||
| let buf = new ArrayBuffer(str.length * 2); // 2 bytes for each char | ||
| let bufView = new Uint16Array(buf); | ||
| for (let i = 0, strLen = str.length; i < strLen; i++) { | ||
| bufView[i] = str.charCodeAt(i); | ||
| } | ||
| return buf; | ||
| }; | ||
|
|
||
| const printArrayBuffer = (buffer) => { | ||
| let view = new Uint8Array(buffer); | ||
| return Array.from(view); | ||
| }; |
There was a problem hiding this comment.
Having seen this in a bunch of places at this point - maybe move them to a helper functio( in another PR)?
There was a problem hiding this comment.
I was asking myself the same question but ended up this way since I wanted that example to be "completed" (without the need to have multiple files), just copy/run. Do you think it makes sense?
olegbespalov
force-pushed
the
feat/ecdsa
branch
from
b965aca to
6ca2bdd
Compare
mstoykov
reviewed
Apr 17, 2024
| } | ||
|
|
||
| resolve(rt.NewArrayBuffer(signature)) |
There was a problem hiding this comment.
Same problem as in the previous PRs with using the runtime in a goroutine off the event loop
There was a problem hiding this comment.
yeah, but I'd like to do this separately (in ~1h I'll push a PR with fixing all methods)
There was a problem hiding this comment.
See a draft #75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is based on #67 and extends support of elliptic curves in xk6-webcrypto.
It brings support to the ECDSA for the following methods:
It also brings the
spkiformat support for both ECDH and ECDSA.Why?
Closes: #48
Closes: #70