Align configuration with OpenTelemetry SDK, HTTP exporter #5
Conversation
olegbespalov
requested review from
mstoykov and
joanlopez
and removed request for
a team
olegbespalov
force-pushed
the
feat/configuration
branch
from
c71e28e
to
d4fff88
Compare
|
Looks good to me! 👍 |
Co-authored-by: Joan López de la Franca Beltran <[email protected]>
olegbespalov
force-pushed
the
feat/configuration
branch
from
abd91b2
to
612399f
Compare
| func NewConfig(p output.Params) (Config, error) { | ||
| cfg := Config{ | ||
| MetricPrefix: "", | ||
| ReceiverType: grpcReceiverType, | ||
| GRPCReceiverEndpoint: "localhost:4317", | ||
| PushInterval: 1 * time.Second, | ||
| FlushInterval: 1 * time.Second, | ||
| ServiceName: "k6", | ||
| ServiceVersion: k6Const.Version, | ||
| MetricPrefix: "", | ||
| ExporterType: grpcExporterType, | ||
|
|
||
| HTTPExporterInsecure: null.BoolFrom(false), | ||
| HTTPExporterEndpoint: "localhost:4318", | ||
| HTTPExporterURLPath: "/v1/metrics", | ||
|
|
||
| GRPCExporterInsecure: null.BoolFrom(false), | ||
| GRPCExporterEndpoint: "localhost:4317", | ||
|
|
||
| ExportInterval: 1 * time.Second, | ||
| FlushInterval: 1 * time.Second, |
There was a problem hiding this comment.
nit: In general it is better idea to always use null types for everything as that lets you know if you should use a default value or if somebody just managed to match it.
There was a problem hiding this comment.
Implemented as part of: #11
| for k, v := range p.Environment { | ||
| switch k { | ||
| case "K6_OTEL_PUSH_INTERVAL": | ||
| cfg.PushInterval, err = time.ParseDuration(v) | ||
| if err != nil { | ||
| return cfg, fmt.Errorf("error parsing environment variable 'K6_OTEL_PUSH_INTERVAL': %w", err) | ||
| } | ||
| case "K6_OTEL_SERVICE_NAME": | ||
| cfg.ServiceName = v | ||
| case "K6_OTEL_SERVICE_VERSION": | ||
| cfg.ServiceVersion = v |
There was a problem hiding this comment.
Not certain if jut using envconfig.Process as all the other outputs will not be better especially before we move the whole configuration over to not using envconfig.
There was a problem hiding this comment.
Also, implemented as part of: #11
|
@mstoykov, both comments are relevant. I'll try to implement the following configuration-related PRs. This is mostly about aligning with OpenTelemetry terms, so will merge this as it is for now 👍 |
What?
This PR aligns configuration (k6 environment variables) with the OpenTelemetry SDK and introduces more configuration options, along with the HTTP metric exporter.
Why?
It's essential to be aligned so as not to confuse the users, as proven in the comment.