Apply suggestions from code review

Co-authored-by: Joan López de la Franca Beltran <[email protected]>
grafana · May 24, 2024 · abd91b2 · abd91b2
1 parent d4fff88
commit abd91b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/opentelemetry/config.go b/pkg/opentelemetry/config.go
@@ -31,7 +31,6 @@ type Config struct {
 	FlushInterval time.Duration
 
 	// ExporterType sets the type of OpenTelemetry Exporter to use
-	// Currently only "grpc" is supported
 	ExporterType string
 	// ExportInterval configures the intervening time between metrics exports
 	ExportInterval time.Duration
@@ -144,7 +143,7 @@ func (c Config) Validate() error {
 
 	if c.ExporterType != grpcExporterType && c.ExporterType != httpExporterType {
 		return fmt.Errorf(
-			"unsupported exporter type %q, currently only %q and %q supported",
+			"unsupported exporter type %q, currently only %q and %q are supported",
 			c.ExporterType,
 			grpcExporterType,
 			httpExporterType,

diff --git a/pkg/opentelemetry/config_test.go b/pkg/opentelemetry/config_test.go
@@ -61,7 +61,7 @@ func TestConfig(t *testing.T) {
 
 		"unsupported receiver type": {
 			env: map[string]string{"K6_OTEL_GRPC_EXPORTER_ENDPOINT": "else", "K6_OTEL_EXPORT_INTERVAL": "4m", "K6_OTEL_EXPORTER_TYPE": "socket"},
-			err: `error validating OpenTelemetry output config: unsupported exporter type "socket", currently only "grpc" and "http" supported`,
+			err: `error validating OpenTelemetry output config: unsupported exporter type "socket", currently only "grpc" and "http" are supported`,
 		},
 	}