Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop getting k6 version "latest" from CI tasks #993

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Aug 4, 2023

Please see the commit descriptions. This PR will prevent errors as in here.

Related: #992.
Related: grafana/k6#3250 and grafana/k6#3252.

@inancgumus inancgumus changed the title Upgrade to the latest tagged k6 Upgrade to the latest tagged k6: v0.45.1/b7f040bd431a Aug 4, 2023
@inancgumus inancgumus changed the title Upgrade to the latest tagged k6: v0.45.1/b7f040bd431a Drop "latest" from CI tasks Aug 7, 2023
k6 v0.45.1 is failing with go get and go getting with "latest" causes
our CI to fail, too. It was working so far, but with the regression
in v0.45.0, the CI task has stopped working.
@inancgumus inancgumus requested review from ankur22 and ka3de August 7, 2023 08:03
@inancgumus inancgumus self-assigned this Aug 7, 2023
@inancgumus inancgumus added ci compatibility k6 core compatibility labels Aug 7, 2023
@inancgumus inancgumus changed the title Drop "latest" from CI tasks Drop getting k6 version "latest" from CI tasks Aug 7, 2023
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit 9d71ade into main Aug 7, 2023
@inancgumus inancgumus deleted the update/k6-v0.45.1 branch August 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci compatibility k6 core compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants