Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/grafana/xk6-output-prometheus-remote to v0.2.3 #3250

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Aug 4, 2023

This also fixes k6 and dependencies not building due to the deprecation of go.buf.build.

See https://buf.build/docs/migration-guides/migrate-remote-generation-alpha

Also update google.golang.org/protobuf to v1.31.0

This also fixes k6 and dependencies not building due to the deprecation
of go.buf.build.

See https://buf.build/docs/migration-guides/migrate-remote-generation-alpha

Also update google.golang.org/protobuf to v1.31.0
@mstoykov mstoykov force-pushed the updatePrometheusRemoteWriteOutput branch from 69d421b to 0b1bb16 Compare August 4, 2023 09:26
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 for the CI to be green

@mstoykov mstoykov requested a review from oleiade August 4, 2023 09:33
@codecov-commenter
Copy link

Codecov Report

Merging #3250 (9a98856) into master (447b159) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 9a98856 differs from pull request most recent head 0b1bb16. Consider uploading reports for the commit 0b1bb16 to get more accurate results

@@            Coverage Diff             @@
##           master    #3250      +/-   ##
==========================================
- Coverage   73.23%   73.10%   -0.13%     
==========================================
  Files         259      257       -2     
  Lines       19899    19894       -5     
==========================================
- Hits        14573    14544      -29     
- Misses       4402     4420      +18     
- Partials      924      930       +6     
Flag Coverage Δ
ubuntu 73.10% <ø> (-0.05%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@mstoykov mstoykov merged commit 636747f into master Aug 4, 2023
@mstoykov mstoykov deleted the updatePrometheusRemoteWriteOutput branch August 4, 2023 09:50
inancgumus added a commit to grafana/xk6-browser that referenced this pull request Aug 4, 2023
This solves the following problem:
grafana/k6#3250
inancgumus added a commit to grafana/xk6-browser that referenced this pull request Aug 4, 2023
This solves the following problem:
grafana/k6#3250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants