Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multierror and refactor to Go errors.Join #850

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Remove multierror and refactor to Go errors.Join #850

merged 2 commits into from
Feb 14, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Apr 7, 2023 •
edited
Loading

This should be merged after upgrading Go's previous version on CI (currently 1.19) to 1.20. Currently, the tests fail because of that.

Updates #738.

@inancgumus inancgumus self-assigned this Apr 7, 2023
@inancgumus inancgumus requested review from ka3de and ankur22 April 11, 2023 10:50
ka3de
ka3de reviewed Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to get rid of this code! 👏
One question. Should we update go.mod's go version to 1.20 besides the go versions in CI also?

ankur22
ankur22 previously approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@inancgumus
Copy link
Member Author

Should we update go.mod's go version to 1.20 besides the go versions in CI also?

@ka3de, that makes sense. But k6 still uses Go 1.19 in go.mod 🤔

@ka3de
Copy link
Collaborator

ka3de commented May 8, 2023

But k6 still uses Go 1.19 in go.mod

But this errors.Join requires go v1.20 right? So we'll have to wait for k6 to upgrade then?

@inancgumus inancgumus force-pushed the refactor/738-multierr-to-gomultierr branch from 6c25fcb to 6573e2e Compare August 17, 2023 16:35
@inancgumus inancgumus mentioned this pull request Feb 12, 2024
Closed
@inancgumus inancgumus force-pushed the refactor/738-multierr-to-gomultierr branch from 6573e2e to 67b5bef Compare February 14, 2024 06:50
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github actions Go versions
8d0a559 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19, it's Go 1.21.
- Let the actions pick the latest version with 1.x.
@inancgumus inancgumus mentioned this pull request Feb 14, 2024
Merged
3 tasks
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github actions Go versions
de9437b 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
383cddb 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
a158dd5 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
977aaf1 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
83f1f68 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
f61e483 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
99b3462 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
2a276f8 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
e65a414 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
@inancgumus inancgumus changed the base branch from main to bump/github-action-go-versions February 14, 2024 08:14
@inancgumus inancgumus requested a review from ankur22 February 14, 2024 08:52
@inancgumus
Copy link
Member Author

@ankur22 I'll remove the last commit after merging #1216.

ankur22
ankur22 previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
b517576 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
@inancgumus inancgumus force-pushed the bump/github-action-go-versions branch from e65a414 to b517576 Compare February 14, 2024 10:30
Base automatically changed from bump/github-action-go-versions to main February 14, 2024 10:39
@inancgumus inancgumus dismissed ankur22’s stale review February 14, 2024 10:39

The base branch was changed.

inancgumus added a commit that referenced this pull request Feb 14, 2024
@inancgumus
Bump Github linter and test actions Go versions
e3fa370 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
@inancgumus inancgumus force-pushed the refactor/738-multierr-to-gomultierr branch from c5e386f to a3c30a7 Compare February 14, 2024 10:39
@inancgumus inancgumus requested a review from ankur22 February 14, 2024 10:51
ankur22
ankur22 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@inancgumus inancgumus merged commit 028b4c1 into main Feb 14, 2024
17 checks passed
@inancgumus inancgumus deleted the refactor/738-multierr-to-gomultierr branch February 14, 2024 10:58
@inancgumus inancgumus mentioned this pull request Feb 16, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka3de ka3de ka3de left review comments

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
maintenance refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inancgumus @ka3de @ankur22