Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump linter and test Github action Go versions #1216

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Bump linter and test Github action Go versions #1216

merged 1 commit into from
Feb 14, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Feb 14, 2024 •
edited
Loading

What?

Fixes and bumps the Go versions for the linter and test Github actions.

Why?

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#850, #1214, #1212

@inancgumus inancgumus self-assigned this Feb 14, 2024
@inancgumus inancgumus force-pushed the bump/github-action-go-versions branch from 8d0a559 to 44ad4a0 Compare February 14, 2024 07:13
@inancgumus inancgumus changed the title Bump and fix Github action Go versions Bump linter Github action Go versions Feb 14, 2024
@inancgumus inancgumus force-pushed the bump/github-action-go-versions branch 8 times, most recently from 99b3462 to 2a276f8 Compare February 14, 2024 07:57
@inancgumus inancgumus changed the title Bump linter Github action Go versions Bump linter and test Github action Go versions Feb 14, 2024
@inancgumus inancgumus force-pushed the bump/github-action-go-versions branch from 1849a32 to e65a414 Compare February 14, 2024 08:13
@inancgumus inancgumus requested a review from ankur22 February 14, 2024 08:13
@inancgumus inancgumus marked this pull request as ready for review February 14, 2024 08:13
@inancgumus inancgumus mentioned this pull request Feb 14, 2024
Merged
ankur22
ankur22 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus
Bump Github linter and test actions Go versions
b517576 
- Linter wasn't working after #850 change.
- The previous version is no longer Go 1.19.
@inancgumus inancgumus force-pushed the bump/github-action-go-versions branch from e65a414 to b517576 Compare February 14, 2024 10:30
@inancgumus inancgumus merged commit e3fa370 into main Feb 14, 2024
17 checks passed
@inancgumus inancgumus deleted the bump/github-action-go-versions branch February 14, 2024 10:39
@BrewTestBot BrewTestBot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
ci maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22