Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6-core compatibility: Use the Goja fork called Sobek #1377

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jun 7, 2024

What?

  • Moving to a Goja fork called Sobek.
  • The first PR is produced via an automatic find and replace process. I've also checked the result after doing that, ran the tests, and so on. It seems pretty safe.
  • The rest of the PRs partially refactor some parts of the code on a best-effort basis for linter warnings. I've added these additional commits to this same PR because the linter was terribly failing. Since the linter failings due to the same PR's first commit, I've included them in the same PR.

Why?

See:

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related issue

#1362

@mstoykov
Copy link
Contributor

mstoykov commented Jun 7, 2024

If you want you can replace the import but keep the name as in import goja "github.com/grafana/sobek"

As otherwise this goes and touches more or less each of your functions which than triggers the linter.

It will still be nice if you go through it and change to sobek at some point - just maybe to not block this PR and to make it a bit ... smaller.

@inancgumus
Copy link
Member Author

inancgumus commented Jun 7, 2024

@mstoykov

Since we'll eventually do this, I'd like to go with sobek as it's the official name of our Goja fork now, and done with this work once and for all. I'll also fix the linter warnings, as I see this as a good opportunity to get rid of some of them. Thanks for the suggestion :)

@inancgumus inancgumus marked this pull request as ready for review June 7, 2024 13:37
@inancgumus inancgumus requested a review from ankur22 June 7, 2024 13:37
@inancgumus inancgumus self-assigned this Jun 7, 2024
@inancgumus inancgumus added compatibility k6 core compatibility refactor labels Jun 7, 2024
@inancgumus inancgumus mentioned this pull request Jun 7, 2024
@inancgumus inancgumus requested a review from mstoykov June 7, 2024 13:38
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞 🚀

@inancgumus inancgumus merged commit ffcc1f5 into main Jun 7, 2024
23 checks passed
@inancgumus inancgumus deleted the sobek branch June 7, 2024 14:08
@inancgumus inancgumus changed the title Update to a Goja fork called Sobek k6-core compatibility: Use the Goja fork called Sobek Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility k6 core compatibility refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants