-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k6-core compatibility: Use the Goja fork called Sobek #1377
Conversation
If you want you can replace the import but keep the name as in As otherwise this goes and touches more or less each of your functions which than triggers the linter. It will still be nice if you go through it and change to |
Since we'll eventually do this, I'd like to go with |
More info in: - grafana/k6#3772 - grafana/k6#3773
This happens due to Sobek aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞 🚀
What?
Why?
See:
Checklist
Related issue
#1362